MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    new update/upgrade script, ready for testing

    Scheduled Pinned Locked Moved General Discussion
    328 Posts 27 Posters 659.1k Views 24 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • bheplerB Offline
      bhepler Module Developer
      last edited by

      I just gave this a try on my house mirror. I didn’t apply and received the following output:

      doing test run = true
      update log will be in /home/pi/MagicMirror/installers/upgrade.log
      saving custom.css
      bash: line 92: [: !=: unary operator expected
      upgrading from version 2.8.0 to 2.9.0
      fetching latest revisions
      there are 1 local files that are different than the master repo
      
         package-lock.json
      
      any *-lock.json files do not need to be saved
      do you want to save these files for later   (Y/n)?n
      skipping restore for package-lock.json, doing test run
      
      processing dependency changes for active modules with package.json files
      processing for module MMM-MovieListings . please wait
      ----------------------------------
      skipped processing for MMM-MovieListings, doing test run
      processing for module MMM-Ring . please wait
      ----------------------------------
      skipped processing for MMM-Ring, doing test run
      processing for module MMM-DarkSkyForecast . please wait
      ----------------------------------
      skipped processing for MMM-DarkSkyForecast, doing test run
      restoring custom.css
      bash: line 260: [: !=: unary operator expected
      

      This seems wrong. What can I do to help?

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @bhepler
        last edited by

        @bhepler ok, try again, fixed… assumed locale was set, wasn’t

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        bheplerB 1 Reply Last reply Reply Quote 0
        • BKeyportB Offline
          BKeyport Module Developer @sdetweil
          last edited by

          @sdetweil I will clearly keep it watched… thanks for the info!

          The "E" in "Javascript" stands for "Easy"

          1 Reply Last reply Reply Quote 0
          • R Offline
            rabbit83ka @sdetweil
            last edited by

            @sdetweil Same error than @satsatt

            I had to restore custom.css because the git-reset deleted it (script backed up custom.css correctly).

            S 2 Replies Last reply Reply Quote 0
            • S Offline
              sdetweil @rabbit83ka
              last edited by

              @rabbit83ka hm… can u send me the install.log? same userid as here on gmail

              i fixed the error that @satsatt had (or so I thought)
              i check for english locale, if not set or not current, I add an alias to use english to get the right message output
              then restore the the alias or remove it…

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • S Offline
                sdetweil @rabbit83ka
                last edited by

                @rabbit83ka said in new update/upgrade script, ready for testing:

                restore custom.css because the git-reset

                yes, starting with version 2.9.0 they will no longer track it so changes should not be lost…
                I will leave the save/restore in

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                Mykle1M 1 Reply Last reply Reply Quote 0
                • Mykle1M Offline
                  Mykle1 Project Sponsor Module Developer @sdetweil
                  last edited by

                  @sdetweil

                  Used your update/upgrade script last night. No issues. Thank you, Sam. :thumbsup:

                  MM 2.8.0 -> 2.9.0
                  Ubuntu 18.04.3

                  Create a working config
                  How to add modules

                  S 1 Reply Last reply Reply Quote 0
                  • S Offline
                    sdetweil @Mykle1
                    last edited by

                    @Mykle1 cool… did u have extra modules also ?

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    Mykle1M 1 Reply Last reply Reply Quote 0
                    • Mykle1M Offline
                      Mykle1 Project Sponsor Module Developer @sdetweil
                      last edited by

                      @sdetweil said in new update/upgrade script, ready for testing:

                      cool… did u have extra modules also ?

                      Meaning other than the defaults? I have nearly all of my modules installed, as well as my favorites from other devs. Did something happen to them? hahah

                      Create a working config
                      How to add modules

                      S 2 Replies Last reply Reply Quote 0
                      • S Offline
                        sdetweil @Mykle1
                        last edited by

                        @Mykle1 no. Just checking on how it was handled.

                        Could u email me the Upgrade log

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        Mykle1M 1 Reply Last reply Reply Quote 0
                        • Mykle1M Offline
                          Mykle1 Project Sponsor Module Developer @sdetweil
                          last edited by

                          @sdetweil

                          Where is it saved to? I can’t seem to find it in Home or the MagicMirror dir

                          Create a working config
                          How to add modules

                          S 1 Reply Last reply Reply Quote 0
                          • S Offline
                            sdetweil @Mykle1
                            last edited by sdetweil

                            @Mykle1 in the installers folder… (where the install script is and where the upgrade and pm2 scripts should go

                            dang it… u mean you didn’t READ the message the script put out about where the log is? lol…

                            Sam

                            How to add modules

                            learning how to use browser developers window for css changes

                            Mykle1M 1 Reply Last reply Reply Quote 0
                            • Mykle1M Offline
                              Mykle1 Project Sponsor Module Developer @sdetweil
                              last edited by

                              @sdetweil said in new update/upgrade script, ready for testing:

                              u mean you didn’t READ the message the script put out about where the log is? lol…

                              uhhhh . . . real men don’t read messages. ;-)

                              Sent the file to your gmail

                              Create a working config
                              How to add modules

                              1 Reply Last reply Reply Quote 0
                              • bheplerB Offline
                                bhepler Module Developer @sdetweil
                                last edited by

                                @sdetweil - Hmm. Curious. Test run of the script looked good. Added the apply keyword and I’m getting a git error.

                                any *-lock.json files do not need to be saved
                                do you want to save these files for later   (Y/n)?n
                                fatal: Unable to create '/home/pi/MagicMirror/.git/index.lock': File exists.
                                
                                Another git process seems to be running in this repository, e.g.
                                an editor opened by 'git commit'. Please make sure all processes
                                are terminated then try again. If it still fails, a git process
                                may have crashed in this repository earlier:
                                remove the file manually to continue.
                                
                                there were merge errors
                                you should examine and resolve them
                                using the command git log --oneline --decorate
                                a31546b (HEAD -> master, tag: v2.8.0) Merge pull request #1717 from MichMich/develop
                                

                                Then a bunch of commit statements. There is no git process running at the moment, but that index.lock file does exist. After deleting that file, it worked like a charm. Thanks!

                                S 2 Replies Last reply Reply Quote 0
                                • S Offline
                                  sdetweil @bhepler
                                  last edited by sdetweil

                                  @bhepler said in new update/upgrade script, ready for testing:

                                  but that index.lock file does exist

                                  to git that means it is already running… on exit it cleans up…

                                  should I add handling this error to the script?
                                  I can tell if its there and git is not running.

                                  great feedback… thanks

                                  Sam

                                  How to add modules

                                  learning how to use browser developers window for css changes

                                  1 Reply Last reply Reply Quote 0
                                  • S Offline
                                    sdetweil @bhepler
                                    last edited by

                                    @bhepler i added handling for the git lock file…

                                    if git is NOT running, I erase the dangling lock file
                                    if git IS running, and this is an APPLY run, i change the run back to test mode, and advise to correct the problem

                                    Sam

                                    How to add modules

                                    learning how to use browser developers window for css changes

                                    1 Reply Last reply Reply Quote 2
                                    • Mykle1M Offline
                                      Mykle1 Project Sponsor Module Developer
                                      last edited by

                                      I just did another run of your upgrade script, Sam. All went well.

                                      MM 2.8.0 --> 2.9.0
                                      Ubuntu 16.04.6 (downgraded from 18.04)

                                      Create a working config
                                      How to add modules

                                      S 1 Reply Last reply Reply Quote 0
                                      • S Offline
                                        sdetweil @Mykle1
                                        last edited by

                                        @Mykle1 on the 1st run, no modules were updated… there should have been a message in the log… i didn’t see it… did u see any this time??

                                        Sam

                                        How to add modules

                                        learning how to use browser developers window for css changes

                                        Mykle1M 1 Reply Last reply Reply Quote 0
                                        • Mykle1M Offline
                                          Mykle1 Project Sponsor Module Developer @sdetweil
                                          last edited by

                                          @sdetweil

                                          Sorry, I was distracted here, Sam. I just emailed you the upgrade.log

                                          Create a working config
                                          How to add modules

                                          S 1 Reply Last reply Reply Quote 0
                                          • S Offline
                                            sdetweil @Mykle1
                                            last edited by

                                            @Mykle1 thanks… they(last night and today) actually look good
                                            i did make one change, the merge results generated one LONE line… i added some formatting to make it readable

                                            Sam

                                            How to add modules

                                            learning how to use browser developers window for css changes

                                            1 Reply Last reply Reply Quote 1

                                            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

                                            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

                                            With your input, this post could be even better 💗

                                            Register Login
                                            • 1
                                            • 2
                                            • 3
                                            • 4
                                            • 5
                                            • 6
                                            • 16
                                            • 17
                                            • 4 / 17
                                            • First post
                                              Last post
                                            Enjoying MagicMirror? Please consider a donation!
                                            MagicMirror created by Michael Teeuw.
                                            Forum managed by Sam, technical setup by Karsten.
                                            This forum is using NodeBB as its core | Contributors
                                            Contact | Privacy Policy