After update 2.23.0 crash

sdetweil

@swvalenti yes, there is no package.json describing the dependencies…

some of the local add on scripts use request and jsdom and others…

sdetweil

@JerryP said in After update 2.23.0 crash:

/home/pi/MagicMirror/package-lock.json

erase that file… seems u might have used sudo at some time before …

sudo rm /home/pi/MagicMirror/package-lock.json

then npm install again

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti yes, there is no package.json describing the dependencies…

some of the local add on scripts use request and jsdom and others…

So I should revert back to 2.22 then?

JerryP

@sdetweil

pi@raspberrypi:~/MagicMirror $ ls
 CHANGELOG.md   Collaboration.md   core  'DISPLAY=:0'   index.html   jest.config.js   jsconfig.json   magicmirror@2.23.0   module-types.ts   oud         run-start.sh   splashscreen   th.json        vendor
 clientonly     config             css    fonts         installers   js               LICENSE.md      modules              node_modules      README.md   serveronly     tests          translations
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/pi/MagicMirror/node_modules/acorn
npm ERR! dest /home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/pi/MagicMirror/node_modules/acorn' -> '/home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_43_20_803Z-debug-0.log

sdetweil

@swvalenti no, i think you got bit by the security cleanup

if a package is not listed in the (any) dependencies and you run npm install it will be removed…

so, go thru the requires in the .js files and do this for each one

https://forum.magicmirror.builders/topic/15778/fix-for-black-screen-in-2-16-and-later

sdetweil

@JerryP fun, fun

rm -rf node_modules

and then npm install again

JerryP

@sdetweil same error

pi@raspberrypi:~/MagicMirror $ rm -rf node_modules
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /home/pi/MagicMirror/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/MagicMirror/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_47_07_273Z-debug-0.log
pi@raspberrypi:~/MagicMirror $

sdetweil

@JerryP looks like u got carried away with sudo rm /home/pi/MagicMirror/package-lock.json (notice the -lock)

and deleted the package.json

git checkout package.json

and npm install again

swvalenti

@JerryP said in After update 2.23.0 crash:

@sdetweil

pi@raspberrypi:~/MagicMirror $ ls
 CHANGELOG.md   Collaboration.md   core  'DISPLAY=:0'   index.html   jest.config.js   jsconfig.json   magicmirror@2.23.0   module-types.ts   oud         run-start.sh   splashscreen   th.json        vendor
 clientonly     config             css    fonts         installers   js               LICENSE.md      modules              node_modules      README.md   serveronly     tests          translations
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/pi/MagicMirror/node_modules/acorn
npm ERR! dest /home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/pi/MagicMirror/node_modules/acorn' -> '/home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_43_20_803Z-debug-0.log

That didn’t work, no worries I will revert

sdetweil

@swvalenti what didn’t work?

u are supposed to be doing the npm install of the missing libs in the module (MMM-PGA) folder

i don’t think revert will help, the undocumented libraries were deleted by npm… not us

that .acorn file needs to be deleted

swvalenti

@swvalenti said in After update 2.23.0 crash:

@JerryP said in After update 2.23.0 crash:

@sdetweil

pi@raspberrypi:~/MagicMirror $ ls
 CHANGELOG.md   Collaboration.md   core  'DISPLAY=:0'   index.html   jest.config.js   jsconfig.json   magicmirror@2.23.0   module-types.ts   oud         run-start.sh   splashscreen   th.json        vendor
 clientonly     config             css    fonts         installers   js               LICENSE.md      modules              node_modules      README.md   serveronly     tests          translations
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/pi/MagicMirror/node_modules/acorn
npm ERR! dest /home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/pi/MagicMirror/node_modules/acorn' -> '/home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_43_20_803Z-debug-0.log

That didn’t work, no worries I will revert

The package.json showed no issue with that command. It worked when I reverted no issue.

sdetweil

@swvalenti how did you revert?

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti how did you revert?

Copied original file and renamed before using your script.

sdetweil

@swvalenti got it…

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti got it…

Thought maybe the script would catch it. Ha. Oh well thanks for all your help and work.

sdetweil

@swvalenti the script DID catch for request, but not jsdom…

these are the undocumented libs used

OWGR.js:const request = require('request');
OWGR.js:const jsdom = require("jsdom");

I just added that to the upgrade script list of missing libs

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti the script DID catch for request, but not jsdom…

these are the undocumented libs used
OWGR.js:const request = require('request');
OWGR.js:const jsdom = require("jsdom");
I just added that to the upgrade script list of missing libs

Cool so if I update it will work?

sdetweil

@swvalenti should…

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti should…

Thanks Sam I’ll report back

sdetweil

@swvalenti nope it wont work as it is… looks only in the node_helper… oops…

working on fix…

pushed a fix