Stocks

ZTA0796

Upon looking at it further-- in the “socketNotificationReceived: function(notification, payload)” function in the module.js file, it seems that when I run console.log(this.result), it outputs my JSON:

Object { symbol: “MSFT”, price: “62.30”, date: “12/16/2016”, time: “4:00pm”, change: “-0.28”, col1: “62.95”, high: “62.95”, low: “62.12”, col2: “42453083” }

When I go to the “getDom” function and run “console.log(this.result)”, I get:

[object Object]

I’m just not sure why that change occurs, but that seems to be my issue. Any help is massively appreciated!

alexyak

@ZTA0796 The object that you get int the stocks.js is the deserialized javascript object. In your case it’s going to be a single row object. You could just access the properties list this:

this.result.symbol, this.result.price, etc…

-Alex

ZTA0796

@alexyak So that’s what I expected as well. Unfortunately, it is somehow getting messed up between the “socketNotificationReceived” function and the “getDom” function.

socketNotificationReceived: function(notification, payload) {
    if (notification === "STOCKS_RESULT") {
        this.result = payload;
        console.log(this.result);  //prints my JSON correctly console
        this.updateDom(self.config.fadeSpeed);
    }

So the above works correctly. Below, however, it doesn’t seem to maintain and I can’t figure out why.

getDom: function() {

    var wrapper = document.createElement("table");
    wrapper.className = 'normal regular small';
    
    var count = 0;

    var _this = this;

	console.log("result is " + this.result); //prints "result is [object Object]"
	console.log("result length is " + this.result.length); //prints "result length is 0"
	console.log(this.symbol);  //prints "undefined"
    }

I apologize if I’m being thick, but I can’t figure out why it’s not working…

ZTA0796

Ok, so I think i figured it out. Still not sure why it worked, but for some reason, running a console.log("descriptive text " + this) seems to corrupt or change the type of “this”. If I put two consecutive console.log() calls–first with descriptive text, second with just “this”–then it works. Basically in the example above, if I just comment out the first two console.log() calls, then it no longer prints “undefined” and instead prints “MSFT”. Sorry for all the trouble!

Mitch1138

Several weeks ago this module seemed to stop working. It doesn’t generate any errors, just won’t display. Has anyone else seen this?

Thanks, Dave

pugsly

@Mitch1138 Yes same for me, this module no longer works.

Mykle1

@Mitch1138 said in Stocks: > Has anyone else seen this?

@pugsly > Yes same for me, this module no longer works.

At first glance, putting the url into a browser results in a 404 error
http://finance.google.com/finance/info?client=ig&q=.DJI,MSFT,AAPL,GOOG,INTC,CICS,TSLA,FB

cowboysdude

The url in the module no longer works… it won’t give an error it’s a 404 error…

I’m seeing if I can find a url replacement…

homebrew

@alexyak
can’t seem to get this updating on the MM display, any ideas? Was there any change to the original code?

homebrew

@cowboysdude
Did you find a working URL replacement?
Have you been using another Stocks module instead?

cowboysdude

@homebrew No sorry I haven’t. I don’t use stock modules :) I don’t do stocks LOL

BUT if you can find a url that works I can look at the module for you…

homebrew

@Mykle1
have you found a replacement url or just using another stocks module?

Mykle1

@homebrew

Like @cowboysdude, I don’t use stock modules. My interest in this topic was to troubleshoot for @Mitch1138 3 months ago. The API that was being used is no longer available. Cowboysdude and I both looked for a free API but there didn’t seem to be one available at the time.

If you can find a free API then I’ll certainly collaborate with Cowboysdude if he wanted some assistance

goofy

@homebrew
i’m too - i can’t see anything on my display if i use the Stocks module.
I‘m useing mm 2.2.1 on a raspberry pi.

alexyak

I’ve found a web service which provides free intraday stock quotes. You will only need to register to get an API key.

https://www.alphavantage.co/support/#api-key

The code in the module will need to be modified though to parse a different payload result. I will try to update it today or tomorrow.

goofy

@alexyak
Many Thanks - i‘m looking forward.
If you update your code - i will Test it ;)

alexyak

I’ve updated the code to support the new API’s from https://iextrading.com/developer/docs/#stocks. Which BTW, doesn’t even require registration.

shep99

Alexyak this is great thanks! The iex API seems to only support US stocks. Any chance of integrating Alphavantage into this great module? Would love to get some CDN ( TSX ) stocks into it

Thanks!

Mitch1138

Many thanks for all your work Alexyak. I can’t seem to get the stock to display. I am using the default configuration file and this is display on the terminal during execution:

Connecting socket for: stocks
stocks helper started ...
Sockets connected & modules started ...
Launching application.
url:https://api.iextrading.com/1.0/stock/.DJI/quote
url:https://api.iextrading.com/1.0/stock/MSFT/quote
url:https://api.iextrading.com/1.0/stock/AAPL/quote
url:https://api.iextrading.com/1.0/stock/GOOG/quote
url:https://api.iextrading.com/1.0/stock/INTC/quote
url:https://api.iextrading.com/1.0/stock/CICS/quote
url:https://api.iextrading.com/1.0/stock/TSLA/quote
url:https://api.iextrading.com/1.0/stock/FB/quote

Any suggestions?
Thanks, Mitch

goofy

Me too - i do not see anything on my display.
I use the default config too.