Something I'm working on ...

MichMich

@Cato That’s correct. You’re mixing html and markdown. Which is not supported within a markdown table. The markdown parser is very strict about this due to security reasons. (We want to prevent code injection via a readme file at all costs.)

I just use the parser used/developed by/for https://www.npmjs.com, so this is not something I can change.

Cato

@MichMich Are you sure about that?

I thought InLine HTML was perfectly allowed. See:

MichMich

@Cato Yes, it’s allowed, but not within a markdown table.

Cato

Ok, I’ll reformat my documentation when I get time.

I found this nice tool: https://dlaa.me/markdownlint/ for checking syntax.

paphko

Nice step, a dedicated module database :-)
However, via chrome for Android, I am not able to upload an image for my module…

roramirez

@MichMich From some days I’ve been working in design and little code about mention before.

I hope soon release something can be stable. At today is state alfa state and not working.

I send the URL of project if someone is interested
https://github.com/roramirez/MagicMirror-Module-Manager

bmarofsky

@MichMich It would be good to require screenshots. Other wise its a good start.

tosti007

I cannot upload any modules at all, either with pc (windows, firefox) or android (chrome). Is this currently supposed to be like that (aka disabled) or am i doing something wrong? :) I am on the correct github account and the repositories are public.

MichMich

@bmarofsky Not all modules have visuals. Some just work in the background.

MichMich

@tosti007 Doe you notice some particular error in the browser’s console?

tosti007

@MichMich I didn’t check, will do when I have time somewhere later today.

yawns

@tosti007 said in Something I’m working on ...:

I cannot upload any modules at all, either with pc (windows, firefox) or android (chrome). Is this currently supposed to be like that (aka disabled) or am i doing something wrong? :) I am on the correct github account and the repositories are public.

I just tried as well. You can click “Step 1 - Select repository” but nothing happens. The console is showing a HTTP500 error:

vue.js?3de6:5729 Download the Vue Devtools for a better development experience:
https://github.com/vuejs/vue-devtools
vue-resource.common.js?2f13:1071 GET http://beta.magicmirror.builders/api/me/repositories 500 (Internal Server Error)
(anonymous) @ vue-resource.common.js?2f13:1071
PromiseObj @ vue-resource.common.js?2f13:198
xhrClient @ vue-resource.common.js?2f13:1025
sendRequest @ vue-resource.common.js?2f13:1140
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
before @ vue-resource.common.js?2f13:966
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
timeout @ vue-resource.common.js?2f13:1014
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
method @ vue-resource.common.js?2f13:980
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
body @ vue-resource.common.js?2f13:853
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
jsonp @ vue-resource.common.js?2f13:942
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
header @ vue-resource.common.js?2f13:997
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
cors @ vue-resource.common.js?2f13:824
exec @ vue-resource.common.js?2f13:1097
next @ vue-resource.common.js?2f13:1122
(anonymous) @ bootstrap.js?5e63:36
exec @ vue-resource.common.js?2f13:1097
(anonymous) @ vue-resource.common.js?2f13:1125
PromiseObj @ vue-resource.common.js?2f13:198
Client @ vue-resource.common.js?2f13:1090
Http @ vue-resource.common.js?2f13:1350
Http.(anonymous function) @ vue-resource.common.js?2f13:1379
fetchRepositories @ AddModule.vue?5997:99
boundFn @ vue.js?3de6:131
mounted @ AddModule.vue?5997:141
callHook @ vue.js?3de6:1833
insert @ vue.js?3de6:2007
invokeInsertHook @ vue.js?3de6:4159
patch @ vue.js?3de6:4301
Vue._update @ vue.js?3de6:1722
(anonymous) @ vue.js?3de6:1697
get @ vue.js?3de6:740
Watcher @ vue.js?3de6:732
Vue._mount @ vue.js?3de6:1696
Vue$3.$mount @ vue.js?3de6:5716
Vue$3.$mount @ vue.js?3de6:7873
initRender @ vue.js?3de6:2218
Vue._init @ vue.js?3de6:2580
Vue$3 @ vue.js?3de6:2624
(anonymous) @ app.js?8b67:47
(anonymous) @ app-c86aef609d.js:1578
__webpack_require__ @ app-c86aef609d.js:20
(anonymous) @ app-c86aef609d.js:64
(anonymous) @ app-c86aef609d.js:67
AddModule.vue?5997:105 Responsebody: "↵↵    ↵        ↵        ↵        ↵    ↵    ↵                    <div>↵                <h1>Whoops, looks like something went wrong.</h1>↵                                        <h2>↵                            1/1↵                            RuntimeException in <a>Client.php line 70</a>:Pipeline.php line 104↵       <li>at Pipeline->then(<em>object</em>(Closure)) in <a>Router.php line 644</a></li>↵       <li>at Router->runRouteWithinStack(<em>object</em>(Route), <em>object</em>(Request)) in <a>Router.php line 618</a></li>↵       <li>at Router->dispatchToRoute(<em>object</em>(Request)) in <a>Router.php line 596</a></li>↵       <li>at Router->dispatch(<em>object</em>(Request)) in <a>Kernel.php line 267</a></li>↵       <li>at Kernel->Illuminate\Foundation\Http\{closure}(<em>object</em>(Request)) in <a>Pipeline.php line 53</a></li>↵       <li>at Pipeline->Illuminate\Routing\{closure}(<em>object</em>(Request)) in <a>CheckForMaintenanceMode.php line 46</a></li>↵       <li>at CheckForMaintenanceMode->handle(<em>object</em>(Request), <em>object</em>(Closure)) in <a>Pipeline.php line 137</a></li>↵       <li>at Pipeline->Illuminate\Pipeline\{closure}(<em>object</em>(Request)) in <a>Pipeline.php line 33</a></li>↵       <li>at Pipeline->Illuminate\Routing\{closure}(<em>object</em>(Request)) in <a>Pipeline.php line 104</a></li>↵       <li>at Pipeline->then(<em>object</em>(Closure)) in <a>Kernel.php line 149</a></li>↵       <li>at Kernel->sendRequestThroughRouter(<em>object</em>(Request)) in <a>Kernel.php line 116</a></li>↵       <li>at Kernel->handle(<em>object</em>(Request)) in <a>index.php line 53</a></li>↵    ↵</h2></div>↵↵            ↵    ↵"bodyBlob: BlobbodyText: PromiseObjdata: (...)get data: ()arguments: (...)caller: (...)length: 0name: "get"prototype: Object__proto__: ()[[FunctionLocation]]: vue-resource.common.js?2f13:856[[Scopes]]: Scopes[4]set data: (body)arguments: (...)caller: (...)length: 1name: "set"prototype: Object__proto__: ()[[FunctionLocation]]: vue-resource.common.js?2f13:859[[Scopes]]: Scopes[4]headers: Headersmap: Object__proto__: Objectok: falsestatus: 500statusText: "Internal Server Error"url: "/api/me/repositories"__proto__: Object
(anonymous) @ AddModule.vue?5997:105

MichMich

It seems the php-curl module was missing. Could you give it an other try. If it doesn’t work, I need to dive into it.

yawns

Okay, I was able to add my module right now. However now it says it cannot find the readme. This affects all modules, not only mine.

MichMich

@yawns Should be fixed now.

yawns

yes indeed. Thanks @MichMich

tosti007

@yawns thank you for checking the log for me, @MichMich thanks for fixing the readme bug. I will try and upload my modules later.

tosti007

Well it seems I broke stuff, this time with the picture of my uploaded module. It doesn’t display it and when you to to the actual file it gives a NotSupportedException or this one :) My original picture has a size of 558 x 173 (not sure if this is important in any way).

strawberry 3.141

@tosti007 did you probably upload an exotic file extension?

MichMich

Hmm… need to look into this. Will do this later. Thanks for testing.