MMM-doomsDay - The countdown module,

broberg

@Mykle1 humm, okey, probably because the function to round it up thinks it’s more than 0.5 days left and thus rounds it up to 1 instead of down to zero.

Have to adjust the code a bit

Jopyth

@Mykle1 My advent module? Even though @broberg hasn’t mentioned it, it seems he based his work on that module.

A feature suggestion from my side: It would feel more like an urgent thing closing in, if it could also show hours/minutes/seconds, too. Maybe use a formatting string for a moment.js duration? If I have some time, I might make a PR.

broberg

@Mykle1 Okey, I changed up some variables and I’m not able to test them myself, when you get home, could do a git pull on the doomsday module and test it out for me?

broberg

@Jopyth Yes, I stripped out that module for this one, kept the start function and removed the rest since It was a bit over my head at the moment :)

Took me a lot longer than I’m willing to admit just to get the code to compare dates!
Actually thought about the hour/minute countdown as well, but decided to keep it real basic.
I figured you don’t really put that many hours in front of the mirror that it would be that important to see so much detail of the countdown. (And if you look the update interval is set to 5 hours just to keep it in the ballpark)

Mykle1

@Jopyth said in MMM-doomsDay - The countdown module,:

My advent module?

Yes, that was it. :thumbsup_tone1:

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

when you get home, could do a git update on the doomsday module and test it out for me?

This is what I get when I attempted a git update as you suggested.

pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $ git update
git: ‘update’ is not a git command. See ‘git --help’.

Did you mean this?
update-ref
pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $

I don’t want to mess anything up so I’ll wait till you advise further, thanks

strawberry 3.141

@Mykle1 git pull

broberg

@Mykle1 sorry my bad mixing up stuff, git pull is the command to use in the Mmm-doomsday folder

broberg

A second to slow,@strawberry-3-141 beat me to it :)

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

A second to slow,@strawberry-3-141 beat me to it

A photo finish? Thanks to both of you. :thumbsup_tone1:

           {
    			module: 'MMM-doomsDay',
    			position: 'top_left', // This can be any of the regions, best results in center regions
    			config: {
        			doomsDay: "2017-02-24 24:00:00",  // the end day of the countdown, format is YYYY-MM-DD HH:MM:SS, 
        			toWhat: 'Open the pool!',  // the title of your countdown event
				present: 'We are gonna rock',  //  What it should say on doomsDay date
				singular: `Day Left`, // what it should say when it's only one day left, default is `Day Left`
				plural: 'Days Left', // what it should say when it's more days left, default is `Days Left`
				}
		},

Ok, now the display says, “Open the pool!”, but underneath is says, “0 Days Left”

broberg

@Mykle1 okey, then my fix didn’t do what I thought. I have restored it to as before, do a new git pull to get the last version again.

I will have to fix the half-day bug when I get back home :)

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

do a new git pull to get the last version again.

ok, will do. Sorry about the troubles

broberg

@Mykle1 no worries, first versions always have bugs :D

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

no worries, first versions always have bugs

I see you have a new designation.
Congratulations, Mr. Module Developer!

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

first versions always have bugs

Just a follow up. I did the git pull to go back to the original version as you advised. I didn’t disable the module but I did set a new doomsDay for Tuesday. (This was yesterday) The module correctly reported “4 Days Left”. but as of this morning, it still reads "4 Days Left.

broberg

@Mykle1 Finally home, and I believe I have fixed this issue now!
do a new git pull and it should work in the mornings as well :D

@illskool You should also do an update on this module! :D

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

Finally home, and I believe I have fixed this issue now!
do a new git pull and it should work in the mornings as well

Thanks bro. Gonna do that right now.
Ok, I have my test running for tomorrow. The module is correctly displaying “1 Day Left”

{
    			module: 'MMM-doomsDay',
    			position: 'top_right', // This can be any of the regions, best results in center regions
    			config: {
        			doomsDay: "2017-02-27 24:00:00", // the end day of the countdown
        			toWhat: 'Build Bed!', // the title of your countdown event
				present: 'Get to it!',
				singular: 'Day Left', // what it should say when it's only one day left, default is `Day Left`
				plural: 'Days Left', // what it should say when it's more days left, default is `Days Left`
				}
		},

Mykle1

@broberg

It seems I’m still having some problems with this. It worked on the last test, and displayed the present: string correctly, but now it’s not working again. Below is my config with the doomsDay set for tomorrow and a screenshot of the display still reporting 2 Days Left

    			module: 'MMM-doomsDay',
    			position: 'top_right', // This can be any of the regions, best results in center regions
    			config: {
        			doomsDay: "2017-03-01 24:00:00", // the end day of the countdown
        			toWhat: 'Doctor Dave Wed', // the title of your countdown event
				present: 'Doctor Dave 11:30',
				singular: 'Day Left', // what it should say when it's only one day left, default is `Day Left`
				plural: 'Days Left', // what it should say when it's more days left, default is `Days Left`
				}
		},

Mykle1

@Mykle1

Somewhere between now and when I posted my previous comment, the module updated to 1 Day left.

broberg

@Mykle1 I think a higher updateInterval may be in order. the 5 Hours set now maybe is a bit to much,

in the config you can add

updateInterval: 1 * 3600000,

To set it to update every hour instead!