Changing icons of the modules Current Weather and Weather Forecast

j.e.f.f

@vinp said in Changing icons of the modules Current Weather and Weather Forecast:

My CPU goes through the roof when I tried these animated icons last night. Anyone else seeing high CPU usage with them ?

I added the ability to use animated icons in my weather module, and I, too, notice very high CPU usage, even though the animation code is purported to not be demanding of resources. I’m going to guess that SVG / Canvas animation on Electron running or on a Raspberry Pi (or both!) is not optimised to be as efficient as it could be.

If I have many icons animated at the same time and if I leave it running for days, eventually MM will freeze. CPU temp and usage goes up significantly until that happens.

bhepler

@aecandroid - Please check out this guide on how to use the markdown features of the forum. Then go back and properly block out your config.js file. That will make debugging your code much easier.

Mykle1

@aecandroid

Or

https://forum.magicmirror.builders/topic/4247/how-to-post-code-on-the-forum-for-absolute-beginners

aecandroid

@bhepler @Mykle1 My apologies. It was late last night and when I posted the code I saw it had created a block and I didn’t look at it closely. I have properly blocked out my config.js file below. Your help is greatly appreciated.

/* Magic Mirror Config Sample
 *
 * By Michael Teeuw http://michaelteeuw.nl
 * MIT Licensed.
 *
 * For more information how you can configurate this file
 * See https://github.com/MichMich/MagicMirror#configuration
 *
 */

var config = {
	address: "localhost", // Address to listen on, can be:
	                      // - "localhost", "127.0.0.1", "::1" to listen on loopback interface
	                      // - another specific IPv4/6 to listen on a specific interface
	                      // - "", "0.0.0.0", "::" to listen on any interface
	                      // Default, when address config is left out, is "localhost"
	port: 8080,
	ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1"], // Set [] to allow all IP addresses
	                                                       // or add a specific IPv4 of 192.168.1.5 :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.1.5"],
	                                                       // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"],

	language: "en",
	timeFormat: 24,
	units: "metric",

	modules: [
		{
			module: "alert",
		},
		{
			module: "updatenotification",
			position: "top_bar"
		},
		{
			module: "clock",
			position: "top_left"
		},
		{
			module: "calendar",
			header: "UK Holidays",
			position: "top_left",
			config: {
				calendars: [
					{
						symbol: "calendar-check-o ",
						url: "webcal://calendarlabs.com/ical-calendar/ics/75/UK_Holidays.ics"
					}
				]
			}
		},
		 {
			       module: 'MMM-TFL',
			       position: 'bottom_right',    // This can be any of the regions but works best on either side of the display
			       config: {
				               updateTime: 600000,
				               modes: ['tube', 'overground', 'national-rail'],
				               lines: ['c2c', 'bakerloo', 'central', 'district', 'hammersmith-city', 'jubilee', 'metropolitan', 'northern', 'piccadilly', 'victoria', 'waterloo-city'],
				             }
			     },
		{	
			units: "imperial",
			module: "currentweather",
			position: "top_right",
			config: {
				location: "London",
				locationID: "xxx",  //ID from http://www.openweathermap.org/help/city_list.txt
				appid: "xxx"
				iconTable: {
    					'01d': 'wi-day-sunny',
    					'02d': 'wi-day-cloudy',
    					'03d': 'wi-cloudy',
    					'04d': 'wi-cloudy-windy',
    					'09d': 'wi-showers',
    					'10d': 'wi-rain',
    					'11d': 'wi-thunderstorm',
    					'13d': 'wi-snow',
    					'50d': 'wi-fog',
    					'01n': 'wi-night',
    					'02n': 'wi-night-cloudy',
    					'03n': 'wi-night-cloudy',
    					'04n': 'wi-night-cloudy',
    					'09n': 'wi-night-showers',
    					'10n': 'wi-night-rain',
    					'11n': 'wi-night-thunderstorm',
    					'13n': 'wi-night-snow',
    					'50n': 'wi-night-alt-cloudy-windy'
				}
				
		}
		},
		{
			units: "imperial",
			module: "weatherforecast",
			position: "top_right",
			header: "Weather Forecast",
			config: {
				location: "London",
				locationID: "xxx",  //ID from http://www.openweathermap.org/help/city_list.txt
				appid: "xxx"
			}
		},
		{
					module: 		'MMM-UKNationalRail',
					position: 		'bottom_left',
					header:			'Departures',		//Optional - delete this line to turn OFF the header completely
					config: {
									stationCode: 		'xxx', 		// CRS code for station
									app_id: 			'xxx', 		// TransportAPI App ID
									app_key: 			'xxx', 		// TransportAPI App Key
									maxResults: 		5,  		//Optional - Maximum results to display.
									showOrigin: 		false   	//Optional - Show the origin of the train in the table
								}
				},
	]

};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {module.exports = config;}

vinp

@j-e-f-f I also tried out your module for the weather. Looks neat! I also noticed that any animated image in any MM module spikes the CPU. I tried my best at looking at the Electron github project to see if there were any open or closed issues on it. I did not find much. I even tried upgrading my Electron to the latest stable version and that did not help much either.

aecandroid

@aecandroid said in Changing icons of the modules Current Weather and Weather Forecast:

@bhepler @Mykle1 My apologies. It was late last night and when I posted the code I saw it had created a block and I didn’t look at it closely. I have properly blocked out my config.js file below. Your help is greatly appreciated.

/* Magic Mirror Config Sample
 *
 * By Michael Teeuw http://michaelteeuw.nl
 * MIT Licensed.
 *
 * For more information how you can configurate this file
 * See https://github.com/MichMich/MagicMirror#configuration
 *
 */

var config = {
	address: "localhost", // Address to listen on, can be:
	                      // - "localhost", "127.0.0.1", "::1" to listen on loopback interface
	                      // - another specific IPv4/6 to listen on a specific interface
	                      // - "", "0.0.0.0", "::" to listen on any interface
	                      // Default, when address config is left out, is "localhost"
	port: 8080,
	ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1"], // Set [] to allow all IP addresses
	                                                       // or add a specific IPv4 of 192.168.1.5 :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.1.5"],
	                                                       // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"],

	language: "en",
	timeFormat: 24,
	units: "metric",

	modules: [
		{
			module: "alert",
		},
		{
			module: "updatenotification",
			position: "top_bar"
		},
		{
			module: "clock",
			position: "top_left"
		},
		{
			module: "calendar",
			header: "UK Holidays",
			position: "top_left",
			config: {
				calendars: [
					{
						symbol: "calendar-check-o ",
						url: "webcal://calendarlabs.com/ical-calendar/ics/75/UK_Holidays.ics"
					}
				]
			}
		},
		 {
			       module: 'MMM-TFL',
			       position: 'bottom_right',    // This can be any of the regions but works best on either side of the display
			       config: {
				               updateTime: 600000,
				               modes: ['tube', 'overground', 'national-rail'],
				               lines: ['c2c', 'bakerloo', 'central', 'district', 'hammersmith-city', 'jubilee', 'metropolitan', 'northern', 'piccadilly', 'victoria', 'waterloo-city'],
				             }
			     },
		{	
			units: "imperial",
			module: "currentweather",
			position: "top_right",
			config: {
				location: "London",
				locationID: "xxx",  //ID from http://www.openweathermap.org/help/city_list.txt
				appid: "xxx"
				iconTable: {
    					'01d': 'wi-day-sunny',
    					'02d': 'wi-day-cloudy',
    					'03d': 'wi-cloudy',
    					'04d': 'wi-cloudy-windy',
    					'09d': 'wi-showers',
    					'10d': 'wi-rain',
    					'11d': 'wi-thunderstorm',
    					'13d': 'wi-snow',
    					'50d': 'wi-fog',
    					'01n': 'wi-night',
    					'02n': 'wi-night-cloudy',
    					'03n': 'wi-night-cloudy',
    					'04n': 'wi-night-cloudy',
    					'09n': 'wi-night-showers',
    					'10n': 'wi-night-rain',
    					'11n': 'wi-night-thunderstorm',
    					'13n': 'wi-night-snow',
    					'50n': 'wi-night-alt-cloudy-windy'
				}
				
		}
		},
		{
			units: "imperial",
			module: "weatherforecast",
			position: "top_right",
			header: "Weather Forecast",
			config: {
				location: "London",
				locationID: "xxx",  //ID from http://www.openweathermap.org/help/city_list.txt
				appid: "xxx"
			}
		},
		{
					module: 		'MMM-UKNationalRail',
					position: 		'bottom_left',
					header:			'Departures',		//Optional - delete this line to turn OFF the header completely
					config: {
									stationCode: 		'xxx', 		// CRS code for station
									app_id: 			'xxx', 		// TransportAPI App ID
									app_key: 			'xxx', 		// TransportAPI App Key
									maxResults: 		5,  		//Optional - Maximum results to display.
									showOrigin: 		false   	//Optional - Show the origin of the train in the table
								}
				},
	]

};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {module.exports = config;}

I certainly would appreciate anyone’s help on this one.

bhepler

@aecandroid - I’m not seeing anything obviously incorrect with your config. What behavior are you seeing that you wish to fix? Are you getting the module to display at all? Are you getting any modules to display at all? Are you just not getting the icons that you wish?

yawns

You are missing a comma in line appid for currentweather module

				locationID: "xxx",  //ID from http://www.openweathermap.org/help/city_list.txt
				appid: "xxx",
				iconTable: {

aecandroid

@bhepler when I add the iconTable it gives me the screen saying I need to add a config.js file or if one is already added, then to use the javascript line checker. If I delete the icon table, everything works fine.

aecandroid

@yawns too right you are my friend!! The smallest oversight messes up the whole game. Thank you!!