Are you tired of editing config.js, or have trouble doing it, see my new module

sdetweil

in July I changed the processing for compliments… it worked before and the new process changed it to a different approach but still works…

can you do

in the module folder
ls schemas -laF

there should be 4 files related to compliments

these two handle the correction for the possible . in the js object type

-rw-rw-r-- 1 sam sam 2882 Jun 29 07:32 compliments_converter.js
-rw-rw-r-- 1 sam sam 9006 Jul 6 19:14 compliments.schema.json

and these two that improve the form look and feel and handling

-rw-rw-r-- 1 sam sam 381 Jun 28 18:01 compliments_extension.css
-rw-rw-r-- 1 sam sam 1980 Jul 6 19:10 compliments_extension.js

MarcLandis

@sdetweil

-rw-r–r-- 1 dirk dirk 2882 Sep 13 15:23 compliments_converter.js
-rw-r–r-- 1 dirk dirk 381 Sep 13 15:23 compliments_extension.css
-rw-r–r-- 1 dirk dirk 1980 Sep 13 15:23 compliments_extension.js
-rw-r–r-- 1 dirk dirk 9006 Sep 13 15:23 compliments.schema.json

I just did a fresh install of the module, to test something myself

sdetweil

@MarcLandis gosh I hate git changing file dates…

SO, can you do this for me

in the module folder do

node scripts/buildschema4.js …/defaults.js debug >somefile.txt 2>&1

and send me somefile.txt

I’d have you attach it to an issue, but it shows every line from config.js
same id at gmail… and issue attachments are public

MarcLandis

@sdetweil I created a new issue on github and uploaded the file after removing some sensitive information.

sdetweil

@MarcLandis great… thanks

pushed fix to the with_unused_fix branch

git pull
git checkout with_unused_fix
and run the buildschema4 test again

MarcLandis

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

MarcLandis

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

@sdetweil

fixed it myself but ran into the next exception:

calling module data converter script for module=compliments
/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24
		Object.keys(config_data.compliments).forEach(c =>{
		                        ^

TypeError: Cannot read properties of undefined (reading 'compliments')
    at Object.converter (/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24:27)
    at /home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:754:49

sdetweil

@MarcLandis sorry, try again, git pull…

MarcLandis

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@MarcLandis said in Are you tired of editing config.js, or have trouble doing it, see my new module:

@sdetweil

throws an error:

/home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:750
if(module_scripts[m.module] !== undefined ){
^

@sdetweil

fixed it myself but ran into the next exception:
calling module data converter script for module=compliments
/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24
		Object.keys(config_data.compliments).forEach(c =>{
		                        ^

TypeError: Cannot read properties of undefined (reading 'compliments')
    at Object.converter (/home/dirk/MagicMirror/modules/MMM-Config/schemas/compliments_converter.js:24:27)
    at /home/dirk/MagicMirror/modules/MMM-Config/scripts/buildschema4.js:754:49

I f… up

After git pull I have an exception in one of my not published modules. Going to check that first.

sdetweil

@MarcLandis ok i have grandchild lunch at school, back in a couple hours