After update 2.23.0 crash

sdetweil

@swvalenti the script DID catch for request, but not jsdom…

these are the undocumented libs used

OWGR.js:const request = require('request');
OWGR.js:const jsdom = require("jsdom");

I just added that to the upgrade script list of missing libs

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti the script DID catch for request, but not jsdom…

these are the undocumented libs used
OWGR.js:const request = require('request');
OWGR.js:const jsdom = require("jsdom");
I just added that to the upgrade script list of missing libs

Cool so if I update it will work?

sdetweil

@swvalenti should…

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti should…

Thanks Sam I’ll report back

sdetweil

@swvalenti nope it wont work as it is… looks only in the node_helper… oops…

working on fix…

pushed a fix

swvalenti

@sdetweil said in After update 2.23.0 crash:

@swvalenti nope it wont work as it is… looks only in the node_helper… oops…

working on fix…

pushed a fix

Ran upgrade script but still didn’t work same error

sdetweil

@swvalenti can u post the ~/MagicMirror/installers/upgrade.log

swvalenti

@sdetweil Here ya go
https://drive.google.com/file/d/1L5ORoBJlEV6lYSLzJC7VhHM1S1P-jRWy/view?usp=share_link

sdetweil

@swvalenti ok , because you had already done upgrade on this instance. apply doesnt do anything

do force
at the end instead of apply

swvalenti

@sdetweil You are the man worked like a charm. Only thing I noticed when running on windows “alt” does not bring the toolbar up in order to quit MM. Did anything change?

sdetweil

@swvalenti alt-spacebar, or ctrl-m

ctrl-q to quit, if not using pm2.
pm2 will just restart it

swvalenti

@sdetweil ctrl m worked thanks Sam!

JoeFranz

Same here, error after Update :-(
@sdetweil Update with your script

(Use electron --trace-warnings ... to show where the warning was created)
[05.04.2023 07:02.12.571] [ERROR] (node:4893) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
[4932:0405/070214.077646:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[4962:0405/070214.418104:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

JoeFranz

I ran “electron-rebuild”, now it works again :-)

sdetweil

@JoeFranz on what module?

JoeFranz

@sdetweil MMM-PIR-Sensor

Wenike

@sdetweil By chance, do you know of a command I can run to kill any running Node processes? I’m trying to run your upgrade script and its unable to upgrade Node because a process is already running. Googling gives me code to use within an application but that doesn’t seem like it’ll work from the CLI.

doing test run = false
update log will be in /home/pi/MagicMirror/installers/upgrade.log
Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v16.13.1
Installed Node version: v10.24.1
Node should be upgraded.
A Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
running process(s) are
pi 881 879 0 09:05 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js

mumblebaj

@JerryP Always use Sam’s update script. I used it last night and updated from 2.21.0 to 2.23.0 no issues. Often modules with a package.json requires an npm install in that folder and the upgrade script takes care of all of that.

sdetweil

@Wenike do this

from a terminal window

ps -ef | grep node

this will show you the node processes running and parms to what they are running (file path)

if all looks understandable and u can’t terminate them thru app shutdown (pm2 stop all will stop all.managed apps, mm included), do

ps -ef | grep node | awk '{ print $2 }' | xargs kill -9

this will hard kill all the node processes

sdetweil

@JoeFranz

the script does a new npm install in modules that have a package.json

but I know the post install process is wrong for this module

my fork fixes that
https://github.com/sdetweil/MMM-PIR-Sensor