Cant use showEnd icloud cal

[sdetweil]

@blvk sorry, didn’t think it thru

because your events are full day (no time)

DTSTART;VALUE=DATE:20241216

there is no duration

we do not show end for full day events
we could, but don’t

if (this.config.showEnd) {
	if (this.config.showEndsOnlyWithDuration && event.startDate === event.endDate) {
	    // no duration here, don't display end
	} else {
//----- we do this
		timeWrapper.innerHTML += "-";
			timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
	}
}
	// For full day events we use the fullDayEventDateFormat
	if (event.fullDayEvent) {
        	//subtract one second so that fullDayEvents end at 23:59:59, and not at 0:00:00 on the next day
	       event.endDate -= ONE_SECOND;
/// then change the display of both to just the start 
               timeWrapper.innerHTML = CalendarUtils.capFirst(moment(event.startDate, "x").format(this.config.fullDayEventDateFormat));

[sdetweil]

@blvk I just added this to the next release calendar
you can get my test version and try it out
see https://forum.magicmirror.builders/topic/19070/call-for-testers-updated-calendar-module

if showEnd:true, and start date is different then end date, then
add end date on using dateEndFormat
— this (dateEndFormat) might collide with dateEndFormat on events WITH time… need feedback

[evroom]

@sdetweil

At first sight I do not like it too much.
Daily repeating events have an end time now that does not make really sense (23:59) and the Holliday end time only makes sense when the dateEndFormat is extended to see the date.
And that makes it pretty crowded in the date/time column.

IMHO :-)

timeFormat: "absolute",
showEnd: true,
showEndsOnlyWithDuration: true,
//dateEndFormat: "HH:mm",
dateEndFormat: "dddd MMM D - HH:mm",

I currently have
showEndsOnlyWithDuration: true,
but
showEndsOnlyWithDuration: false,
does not seem to do anything.

timeFormat: "absolute",
showEnd: false,
showEndsOnlyWithDuration: true,
dateEndFormat: "HH:mm",
//dateEndFormat: "dddd MMM D - HH:mm",

Regards,

E.J.

[sdetweil]

@evroom thanks… that was what I was afraid of

can you change line calendar.js 439 to be like this, use the FullDayEventFormat, so not different that begin

							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.fullDayEventDateFormat));

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

calendar.js

~/MagicMirror/modules/default/calendar/calendar.js

this.config.fullDayEventDateFormat

showEnd: true,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: true,

[sdetweil]

@evroom that looks better , is it better?
only w duration only applies to date-time events

but same day shouldnt have add end show (but i compared full internal date value, which includes a utc time value which would be different)

its ‘more’ consistent with end showing, but illogical to me to have start and end on the same day

[sdetweil]

@evroom

so try this , new line 437. only show end if the end date is different than the start date

if (this.config.showEnd && moment(event.startDate,"x").format("YYYYMMDD") !== moment(event.endDate,"x").format("YYYYMMDD")) {

[evroom]

@sdetweil

In short, I think it is looking better now.
To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.
The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.
In my examples I only see a change when I toggle ‘showEnd’.

urgency: 0,
timeFormat: "absolute",
dateFormat: "dddd MMM D - HH:mm",
dateEndFormat: "HH:mm",
fullDayEventDateFormat: "dddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
getRelative: 0,

showEnd: true,
showEndsOnlyWithDuration: false,

showEnd: false,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: false,

[sdetweil]

@evroom

you don’t have a full day event across multiple days NOT repeating
example

      vacation mon-friday allday 1 NON-repeating event

repeating are handled differently
show start, but not repeating end
with sliceMultiDayEvents:true, // for REPEATING only (1 day event 5 times)

   see each day of repeating 
       1/5
       2/5
       3/5
       ...
       5/5
then next day 
       2/5
       etc

@evroom said in Cant use showEnd icloud cal:

To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.

sorry, don’t understand this, I thought prior note said TIME display on fullday events was wrong… endFormat is for events with time (IMHO)

The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.

ok, the code here is

					// Add end time if showEnd
					if (this.config.showEnd) {
						if (this.config.showEndsOnlyWithDuration && event.startDate === event.endDate) {
							// no duration here, don't display end
						} else {
							timeWrapper.innerHTML += "-";
							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
						}
					}

BUT,
immediately AFTER this is the test for fullday events, which changes the timeWrapper

So, this would ONLY apply
not-fullday
not repeating
event start on Monday:20:00:end on Tuesday:6:00 sleep over at Bobs

like this

I see the bug… testing 2 things to together

[sdetweil]

@evroom
change lines 415 —

				if (this.config.timeFormat === "absolute") {
					// Use dateFormat
					timeWrapper.innerHTML = CalendarUtils.capFirst(moment(event.startDate, "x").format(this.config.dateFormat));
					// Add end time if showEnd
					if (this.config.showEnd) {
						if (event.startDate !== event.endDate) {
							//  duration here, display end if requested
						  if(this.config.showEndsOnlyWithDuration){
								timeWrapper.innerHTML += "-";
								timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
							}
						}
					}
					// For full day events we use the fullDayEventDateFormat
					if (event.fullDayEvent) {

[evroom]

@sdetweil

Sorry, do not want to cause confusion.
One should probably not do a quick test right after a full working day:-)
The number of test cases seems endless.

Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?

[sdetweil]

@evroom said in Cant use showEnd icloud cal:

The number of test cases seems endless.

indeed… calendar is a tricky beast

Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?
no… the end of this change is just before the prior , match up that last line

working on getting this into the update now, creating testcases!

[sdetweil]

I have posted an updated fixcaldates2

this also resolves the showEndsOnlyWithDuration
and adds support for showEnd:true with full day events (non-repeating)
like vacation mon-fri, all day

just

git pull

to update…
this is my fork, not the official pull request at this time

if you are just getting this for the 1st time. do

git clone https://github.com/sdetweil/MagicMirror.git newmm
cd newmm
git checkout fixcaldates2
npm run install-mm

[evroom]

@sdetweil

Sam,

The option showEndsOnlyWithDuration is not described yet on https://docs.magicmirror.builders/modules/calendar.html.

The interaction / dependancy with showEnd also needs to be documented.

I do not know if documentation issues also can / should be done on https://github.com/MagicMirrorOrg/MagicMirror.

[evroom]

@sdetweil

Sam,

Whilst testing your last changes, I sort of see a need for a new date format parameter.
For an event with duration, spanning multiple days.
E.g. spanningDayEventDateFormat.

[TestCal: TIMESPAN_HOLIDAY]

BEGIN:VEVENT
DTSTART:20241125T110000Z
DTEND:20241127T160000Z
DTSTAMP:20241026T091719Z
UID:1lk06o70p9bp21ln3pdfda4ng0@google.com
CREATED:20241026T090035Z
LAST-MODIFIED:20241026T090035Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: TIMESPAN_HOLIDAY
TRANSP:OPAQUE
END:VEVENT

For events with duration. spanning one night, like an overnight flight, it is not really necessary, but not really bad either.

[TestCal: OVERNIGHT_FLIGH]

BEGIN:VEVENT
DTSTART:20241202T190000Z
DTEND:20241203T030000Z
DTSTAMP:20241026T091719Z
UID:0s4flhmaf7p6q5atemshns4upp@google.com
CREATED:20241026T090148Z
LAST-MODIFIED:20241026T090215Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: OVERNIGHT_FLIGHT
TRANSP:OPAQUE
END:VEVENT

The reasoning behind it is following:
For a ‘normal’, single, event I am not really interested in the full end date format (dateEndFormat).
That is why I normally use dateEndFormat: "HH:mm".
But for an event with duration, spanning multiple days, the setting dateEndFormat: "ddd MMM D - HH:mm" makes more sense.

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[good for normal events, ‘bad’ for spanning events]:

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “ddd MMM D - HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[‘bad’ for normal events, good for spanning events]:

I hope I could explain it well enough.
And that it makes sense. :-)

Best regards,

E.J.

[sdetweil]

@evroom there is a documentation repo

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

[evroom]

@evroom said in Cant use showEnd icloud cal:

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

Opened:
https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues/266

[sdetweil]

@evroom and thinking about it, i think i just messed up the implementation (Which was broken already)

showEnd:true

should show the end for all events fullday or not

showEndsOnlyWithDuration:true should NOT show the end for full day events but DO show end for others ( because of showEnd:true)

[sdetweil]

@evroom i replied there