MMM-forecast-io -- Localized up to the minute weather

twosquirrels

Thanks for this fork! I like your sample screenshot. I cloned it and did npm install, but the sizing of all the colored elements are all way off. Any ideas?

Why is it showing 10 degrees all the way up through 70 when it really only needs to show 70 to 95?

The rain bars are too tiny, as are the temperature range bars. :disappointed_face:

0_1535556499508_CloudApp Annotation 2018-08-29 at 11.28.10 AM.png.png

rak

Hello,

because it meant to be for Grad Celcius and not Grad Fahrenheit. When ever will US go to a metric system ,-).

Fix is easy.

Search in modules/MMM-forecast-io/MMM-forecast-io.js for

id: 'temperature',
            position: 'left',
            ticks: {
              suggestedMin: 10,

and change suggestedMin to you choosing, like 70 … .

Enjoy.

For the bars. You need more space. Make the module wider, or reduce the font size (custom.css).

justindp2006

Been trying to use this module but the width is taking up almost the whole screen. I’m assuming size needs adjusted in the css file but I don’t know which is causing this. Ideas?

barnosch

you can maybe try the following.
Add to your custom.css

.MMM-forecast-io{
transform: scale(0.90, 0.90);
}

Code was not tested. the 0.90 stands for 90%
Maybe that works and is good enough for your needs

otherwise look for the css file within the module folder and play with the settings there

justindp2006

Thank you! So interesting tid-bit. It works on Browser View mode (IP:8080) but on the mirror itself, no changes. I also have trouble with another module. It shows on the Browser, but not at the mirror. It must be something with the Pi Zero image I’m using.

lavolp3

Guys, going through the thread, I see that a lot of good ideas were implemented in forks but not sent as PRs. I think it would be a good idea to have some of these included into the original. dmcinnes/MMM-forecast-io, since this is the one referenced in the original MagicMirror.

@dmcinnes what do you think?
Do you want this rep to be bloated up or do you want it to be kept mostly as it is and leave major changes to forks?

I would expect at least to have some of @morozgrafix very good ideas implemented as optional (sunset, precipitation probability).
Also @rak 's ideas look very very promising but I admit might be a bit much as changes for the master.

morozgrafix

@lavolp3 I haven’t pulled from master repo in a while and not sure if my changes are compatible at this point. I’m happy to clean it up, test it and submit a PR. Just let me know.

lavolp3

@morozgrafix Guess I’ll use the weekend to steal from all of you and build my perfect module. And learn stuff!
Might also send a few PRs then because I’m new to git and it really satisfies me :-D

morozgrafix

@lavolp3 One thing that I would suggest is to group your changes into relevant and smaller size chunks and submit separate PRs for those, instead of one massive PR. It’s easier for reviewers and for you in case you need to make changes based on comments. Cheers.

morozgrafix

@lavolp3 said in MMM-forecast-io -- Localized up to the minute weather:

Guys, going through the thread, I see that a lot of good ideas were implemented in forks but not sent as PRs. I think it would be a good idea to have some of these included into the original. dmcinnes/MMM-forecast-io, since this is the one referenced in the original MagicMirror.

@dmcinnes what do you think?
Do you want this rep to be bloated up or do you want it to be kept mostly as it is and leave major changes to forks?

I would expect at least to have some of @morozgrafix very good ideas implemented as optional (sunset, precipitation probability).
Also @rak 's ideas look very very promising but I admit might be a bit much as changes for the master.

I just submitted a PR for displaying Sunrise and Sunset times. https://github.com/dmcinnes/MMM-forecast-io/pull/22

~~I will try to find some time to improve wind forecast and get another PR submitted sometime this weekend.~~

I also just submitted a PR for wind speed and direction https://github.com/dmcinnes/MMM-forecast-io/pull/23

Precipitation probability forecast is also submitted as a PR: https://github.com/dmcinnes/MMM-forecast-io/pull/24

I also sneaked another PR that allows easy adjustments to forecast table look and feel: https://github.com/dmcinnes/MMM-forecast-io/pull/25