Looking for beta testers for MMM-Remote-Control

Jopyth

Currently the biggest changes to test are:

the new UI for editing the config.js
adding/installing/configuring/removing modules

I am looking for feedback on these steps, as well as:

where confirmation messages should and should not appear
the menu structure updates
ideas on how to assemble a list of all available modules (currently being pulled from the wiki)

done

@Jopyth
Ok, nice one!
Even I’m missing the “switch on for xy minutes” feature ;)

Anyway, what I realized is:

saving the configuration of shown modules causes the mirror to restart. Maybe there should be a confirmation message.
if you press “save” without a change, there could be a message telling you that there is no change and thus restart is not necessary.
on the smartphone landscape doesn’t show the installed mod list, on the tablet it does.
do you need two different switches/lines to show/hide all? Technical reason? Otherwise it could earn you some space.
Netatmo is shown twice in the “New module” list -> probably because it is twice in the wiki as well :)

Installation of new module - I tried the “Callmonitor-Current-Call” - worked smoothly. Even editing the position and header was easy! Sweet!

2nd installation - this time “Motiondetecter” - ended in an error. The mirror crashes in the moment I push the Download button.
Retried to download but it seems like it the pi freezes. Tried to restart but i hang up. Had to disconnect it from the power supply.
Tried again. Same thing. Error while downloading. This time I went back in the menu to restart the mirror. Couldn’t download but the mirror didn’t die. Maybe it’s the motion detector and the neccessary steps to activate the cam module?
The folder “motiondetector” was created but it is empty.

3rd installation - Local Transport - Error after starting to download. The mirror restarted.

Hmm, any module I try causes a crash and restart of the mirror in the moment I press the DL button.

Any information you need?

Nevertheless this is a great configuration tool!

Jopyth

@done Thank you very much!

I am still on the hunt of the restart thing. This is actually a bug, but I am not sure what causes it (if any file in the MagicMirror directory changes, the process restarts). Only happens on the raspberry pi though, and thus harder to debug. If anyone has an idea…

I will see if I can find out what causes the errors on download, since that is the part that actually should work.

It does not show the installed modules list on smartphone in landscape?

Bangee

I’ll join ;-)

rvdgeer

I’ve joined…
Tried some and ran into some trouble…
Will give you a more detailed report when I have the time…

I noticed all parameters and values in config.js are wrapped in quotes…
Maybe that’s why I’m seeing

0|mm       | ** Message: console message: http://localhost:8080/js/main.js @38: TypeError: undefined is not an object (evaluating 'wrapper.appendChild')
0|mm       | ** Message: console message: http://localhost:8080/js/main.js @130: TypeError: null is not an object (evaluating 'moduleWrapper.getElementsByClassName')

The second line is repeated a couple of time (for each module?)…

And when I tried to save eanbled/disabled modules from the remote, the pm2 logs showed an error about insufficient rights…
Sorry for not having the error log…

The config.js now looks like (just a small part):

var config =
{
    "port": 8080,
    "kioskmode": false,
    "language": "nl",
    "timeFormat": 24,
    "units": "metric",
    "modules": [
        {
            "module": "MMM-Remote-Control",
            "config": {}
        },
        {
            "module": "clock",
            "position": "top_left",
            "header": "",
            "config": {
                "displayType": "digital",
                "timeFormat": 24,
                "displaySeconds": false,
                "showPeriod": false,
                "showPeriodUpper": false,
                "clockBold": false,
                "showDate": false,
                "analogSize": "100px",
                "analogFace": "simple",
                "analogPlacement": "bottom",
                "analogShowDate": "top",
                "secondsColor": "#888888"
            }
        },
'''
etcetera...

done

@Jopyth said in Looking for beta testers for MMM-Remote-Control:

It does not show the installed modules list on smartphone in landscape?

Exactly. I just checked again.
I use a Galaxy S6 (just for the dimensions) and I experience that on chrome and the default browser.
I have an idea for the reason.
You work with something like frames.
You have the fix navigation area with “Back”, “Brightness” etc. on top and you have a scrollable list with the installed mods below.
When I go for landscape, there is no chance to get to the scrollable area since the fix area takes already whole of the screen.
The solution could be to make the whole screen scrollable.
At least for small mobile devices.
Or you prevent the browser from going into landscape :D

I guess this is an easy one.

I tried to install modules. MMM-hue and FUEL worked but I had no time to configure them. But they showed on the mirror.

Let me know if I should retry.

Jopyth

@done Yes the fixed area there takes up way to much space.

Does it still do the restart thing? If yes, can you check the output of pm2 show mm and see if Watch & Reload is enabled? I am currently trying to figure out a way to stop pm2 from restarting on changes of files.

Jopyth

@rvdgeer The quotes wrapping should be ok, since whether the key of an object is wrapped in quotes or not, does not make a difference as far as I know. However something is still wrong. Are these console messages coming from your browser?

And did the saving of hidden/shown modules work before you changed to the development branch? Did you change permissions on any folder, and do you have a dedicated user which runs you MagicMirror?

done

@Jopyth said in Looking for beta testers for MMM-Remote-Control:

Does it still do the restart thing?

I installed the new dependencies and now it seems to work. :)

rvdgeer

@Jopyth The console messages are from the pm2 logs…
I run MM as the default user (pi) and didn’t set any special rights for any folders or files…
Now that you mention it, it could be that the saving of the shown/hidden modules didn’t work before either.

BTW: I’m running MM on a Pi Zero (so using ‘serveronly’).

Edit: now that I think about it: I do have a HelloWorld module enabled which already used single and double quotes before. So maybe there’s a conflict with the added quotes. I will look in to this this weekend.

Toast

@Jopyth is there a possibility to include system updates in the remote ? ie “apt dist-upgrade” or whatever subsystem thats used on the system.

Jopyth

@rvdgeer Would be great to find out what causes this and hopefully fix it, however it is still not clear to me, what the reason is. I will investigate a little bit more on the weekend. Maybe I am able to reproduce the issues, could you post your node --version?

In the meantime you could compare your config.js and the config.js.backupX and see if you find possible differences?

rvdgeer

This morning (CET) I have a little more time to do bug reports, troubleshoot and answer some of your questions.
So, first things first.

My node version:
v6.8.1

About the config backups:
I noticed the that the double quotes were added to the keys and values before the backup was made.
This means I don’t have a backup of the true original.
It also means I can only compare the current config file to the backup and not the the original.

Another thing I noticed is that backupfile got overwritten this morning.
Because my MagicMirror is still a work in progress it’s powered off most of the time.
When I tried to reproduce the issues I came across last time I noticed that the first backup I made was saved as config.js.backup1, overwriting a previous backup.
At least for me this wasn;t expected behaviour and I don’t think it’s how I wish to save (or lose) my backups.

About saving hidden/shown modules:
As I said before, I haven’t set any special permisions and I’m using the default useron my Pi Zero: pi
Becasue there’s no keyboard and mouse attached (the Pi Zero’s micro usb port is used for a wifi dongle) I use ssh and scp (and of cource the Remote!) to do most editing, testing and troubleshooting.
On saving the current state of hidden/shown modules the pm2 logs reported this:
On hiding the helloworld module:

0|mm       | ** Message: console message: http://localhost:8080/modules/MMM-Remote-Control//MMM-Remote-Control.js @219: [object Object]
0|mm       | ** Message: console message: http://localhost:8080/js/logger.js @20: helloworld is suspended.
0|mm       | ** Message: console message: http://localhost:8080/js/module.js @313: TypeError: Object is not a function (evaluating 'callback()')

On saving the current state directly after:

0|mm       | ** Message: console message: http://localhost:8080/modules/MMM-Remote-Control//MMM-Remote-Control.js @219: [object Object]
0|mm       | Whoops! There was an uncaught exception...
0|mm       | { Error: EACCES: permission denied, open '/home/pi/MagicMirror/modules/MMM-Remote-Control/settings.json'
0|mm       |     at Error (native)
0|mm       |   errno: -13,
0|mm       |   code: 'EACCES',
0|mm       |   syscall: 'open',
0|mm       |   path: '/home/pi/MagicMirror/modules/MMM-Remote-Control/settings.json' }
0|mm       | MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
0|mm       | If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues

This can be reproduced every time when I follow these steps.
I you need any specific testing, please let me know and I’ll try to find the time.

rvdgeer

And one more.
On restarting I get the following error:

0|mm       | { Error: Command failed: pm2 restart mm
0|mm       |     at ChildProcess.exithandler (child_process.js:206:12)
0|mm       |     at emitTwo (events.js:106:13)
0|mm       |     at ChildProcess.emit (events.js:191:7)
0|mm       |     at maybeClose (internal/child_process.js:877:16)
0|mm       |     at Socket.<anonymous> (internal/child_process.js:334:11)
0|mm       |     at emitOne (events.js:96:13)
0|mm       |     at Socket.emit (events.js:188:7)
0|mm       |     at Pipe._handle.close [as _onclose] (net.js:498:12)
0|mm       |   killed: true,
0|mm       |   code: null,
0|mm       |   signal: 'SIGTERM',
0|mm       |   cmd: 'pm2 restart mm' }
0|mm       | Loading config ...
0|mm       | Loading module helpers ...
0|mm       | No helper found for module: helloworld.
0|mm       | No helper found for module: alert.
0|mm       | Initializing new module helper ...
0|mm       | No helper found for module: clock.
0|mm       | Initializing new module helper ...
0|mm       | Initializing new module helper ...
0|mm       | No helper found for module: currentweather.
0|mm       | No helper found for module: weatherforecast.
0|mm       | Initializing new module helper ...
0|mm       | No helper found for module: compliments.
0|mm       | Initializing new module helper ...
0|mm       | All module helpers loaded.
0|mm       | Starting server op port 8080 ...
0|mm       | Server started ...
0|mm       | Connecting socket for: MMM-Remote-Control
0|mm       | Starting node helper for: MMM-Remote-Control
0|mm       | Connecting socket for: MMM-Traffic
0|mm       | MMM-Traffic helper started ...
0|mm       | Connecting socket for: calendar
0|mm       | Starting node helper for: calendar
0|mm       | Connecting socket for: MMM-NetworkScanner
0|mm       | Starting module: MMM-NetworkScanner
0|mm       | Connecting socket for: newsfeed
0|mm       | Starting module: newsfeed
0|mm       | Sockets connected & modules started ...
0|mm       | Ready to go! Please point your browser to: http://localhost:8080

done

Is there any new version to test?

Jopyth

@done Kind of, yes. I think I have not fixed all mentioned errors, but hopefully the major ones. Also @Mr-Meeseeks added some new functionality (sending alerts).

Feel free to git pull the current status and test again. :) It should no longer mess up config.js files as much, but it still could be. It is using config.js.backupX so make manual backup somewhere else.

Mr.Meeseeks

@rvdgeer do you have pm2 installed and configured? Oh looked above, you do. Well I have noticed even though logs show command error, it still works, I think it’s because node doesn’t surround commands in quotes.