Offline
Meanwhile, there have been some changes to the module list. E.g.
And some more …
That even non-professionals can participate, makes MagicMirror² an exemplary community project. He obviously doesn’t seem to understand that.
All the effort he put into his fork could have been put into the project. That would be much more durable. Apparently, not all people are good at teamwork…
@mumblebaj Cool!
But one hint because I saw this change to the license file: You cannot relicense GPL software under MIT. If you fork a project under the GNU General Public License (GPL), your modified version must also stay under GPL. The GPL’s rules are strict — you can’t change it to a more permissive license like MIT.
@mumblebaj Many thanks for the tips! :smiley:
I have meanwhile written to the operators of the website to see if they can offer an API. If not, I will probably follow your suggested approach.
@bugsounet Sure :-D It’s already in the stats.json.
@PierreGode The wiki page is empty :-(
My Pull Request has been merged :-)
Users have to update the module, then the problem should be solved.
for MagicMirror purposes, is there a preferred style to be used for modules?
@kayakbabe I agree with Sam, but here’s a more detailed answer anyway: This depends on where you are. In some modules there are no rules for this - there and in your own modules it is, as Sam says, up to you.
However, to avoid poor code style, such as spaghetti code and inconsistently formatted code, which not only make maintenance and further development more difficult, but also affect team collaboration, many projects use static code analysis tools such as prettier and ESLint for checking code quality.
In the MagicMirror core (and with this in the default modules), we use the ESLint object-shorthand rule (see https://archive.eslint.org/docs/rules/object-shorthand) to ensure that only the shorthand version is used.
@mumblebaj Thank you for asking! 🙂 Since I want to redesign a few things on the inside, I have not looked for any further discussion for now.
My current plan is roughly this: First make the scripts more efficient (they are currently very storage and time consuming) and then automate the whole process using GitHub hooks and actions. I’ll try to accomplish this in the next few months 🚀
Once I’ve done that, I’ll look for the discussion about the official list.
On this occasion: What is the status of MMM-PGA? 😁 It would be nice if you put at least one of the screenshots into the repository and add keywords in the package.json.