Yes, I know, but I don’t know how to transfer this code-lines to the .css file, the code for appaerance and color were in the module.js file before I began to try to get it work. I only modified them.
The last two problems I have with the module is, to show the correct number in the callist, not “sip:myown number”, when an incomming call is blocket by the “number range list” and to hide the alert of these calls.
On these problems I still work.
Regards
Carsten
I played a little bit around with the colors and changed also the appearance of missed calls, the missed calls now will be displayed in color “magenta” with a “star”. You can edit the colors by yourself by editing the “MMM-Fritz-Box-Callmonitor-py3.js” file, you can’t miss these entrys.
I also edited the README.md file again.
I will push these changes to github at my next update, but I have to test a little bit more because I have to wait for the unwanted calls that are in my blocked “phonenumber range list”, and I don’t know when these unwanted calls are incomming.
But hopefully I got most of the annoying problems under control. :-)
Regards
Carsten
@rkorell said in MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call:
Currently - in my installation - the Info Box which is signalling the call is not a „message-box“ and disappears when call is ended.
Did you modify this -then I would hesitate to install newest version…
Thanks a lot for your effort!
Hi Ralf,
I did not change the appearance of the message-box, in the module it is an alert, I only tried to let it disappear right when you answer the incomming call, because on my MM2 the message box blurres the background and I can not clearly see all other modules and the “MMM-Current-Call” module, that also shows me if the current call is incomming or outgoing, but now the message box disappears when the incomming call is answered.
The MMM-Current-Call" module makes only sense if you have more then one telephon-line, so you can see how many people are talking right now, and if the calls are incomming or outgoing.
Hope that will help you to decide.
Regards
Carsten
Hi Ralf,
I just pushed up my reworked version of the module “MMM-FRITZ-Box-Callmonitor-py3” to github.
I hope it works for you too.
Regards
Carsten
Hi Ralf,
Yes the message box disappears now when a call is in progress, and no I did not push my modificated code to github by now.
But sadly I can’t find out how to let the massage box disapper when a call is incomming that will be blocked. So the message box is displayed over hours on the screen, to let it disappear I have to connect to my MM2 using “RealVNC Viewer” and mouseclick on the message box, then it disappears. This is not satisfying.
With the update of python to version 3.13.2 I made a failure, that was not a good idea, so I have to reinstall my MM2 from scratch, what I’m doing right now. If this is done and all runs like I want again, I will push my modified code to githup. If this is done I will inform you.
I will continue to work on the module to eliminate the last few problems. I hope I can do it.
As I said I can’t code was and is this the truth, all I have done is to try to copy existing code lines change them a little bit and paste it where I thought it could be the right place, then pushed the entirely .js file up to my MM2 and tested it. If it doesn’t work I tried an other way and tested it again. So all I do is “Try and Error”, not really coding! But VSCode helps a lot.
Regards
Carsten
Hi Ralf,
sorry it took a while to answer, what I did until now is:
I updated python on my raspberry pi 4 bookworm 64bit, to python 3.13.2 and I overworked the module MMM-FRITZ-Box Callmonitor-py3, it now handles almost all unwanted (blocked) calls, that are in your FritzBox callist for blocked calls, and shows them in the callist on your MM2.
But it can’t handle blocked numbers that are in the “area list”, that means numbers that begins with e.g. 0031* (+31*) all numbers from, in this example, Netherlands, they appear as “SIP:ownnumber” with a red X in the callist of your MM2. I can’t find out how to fetch the whole correct number that ist displayed in the FritzBox gui under incomming calls.
And I can’t find out how to let the alert “Incomming Call” disappear for that blocked calls.
Everything else should work as expected, for me it does.
Regards,
Carsten
@cgillinger
Hi cgillinger,
I installe your new module “MMM-Birthday-Pages-test” as described, and added the “immersiveMode” to the MM2 main config file.
It seems to work partly, it accepted the positon, on my MM2 “lower_third”, but it ignores the page and it shows some debug informations with green text on the left side by partly hiding the funny icon and parts of the gratulation text.
The fireworks is displayd on fullscreen but in my short test i can’t see the confetti.
A little idea for make it for user a bit easier: make it possible to set the firworks in the MM2 main config-file instead to copy it from to… somthing like “Fireworks: “spiral”” and let it load directly out of the of the “…/fireworks/” folder instead to copy it to the MMM-Birthday-Paged folder.
I will install the “old” MMM-Birthday-paged" and install it as I had it before. It has its own page on my MM2, and it worked very well.
@rkorell said in MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call:
MMM-FRITZ-Box-Callmonitor-py3
Hi Ralf,
I have searched all my log-files in “.pm2/logs/” for that string, but I didn’t find anything related to that error. I don’t have this error in my pm2 log-files.
Are there more log-files I can check, if so where can I find them?
I’m sure you have checked your MagicMirror/config/config.js if there is a type missmatch.
Reguards
Carrsten
Hi Ralf,
I found out that the correct entry for handle “blocked calls” is “10”, not “4”, I found that on “https://fritzconnection.readthedocs.io/en/1.14.0/sources/library_modules.html”
Slowly I understand how the module works and what the entire entries do, but without understandig the syntax and how to code. I will not come further.
Regards
Carsten
I think it is something with the syntax, maybe it has changed somehow in python3, or a wrong set “,” or “;” so the modulescript could not run correct, but it is enough to let the module almost run as expected.
For that I have not enough experience to figure that out.
Would be nice if there were the possebility of a testing enviroment for MS-Windows, so that I could test the scripts. For editing I could use VS-Code.
I have almost 2 hours googled for the right name of the function for the blocked calls, but did not find anythig about that.
And I found some smaller errors in the funktion of the module. E.g. it should delete the alert (the big popup on the gui of the MM when a call comes in) when I answer this call. But that does not work.
This should do the job in the "MMM-FRITZ-Box-Callmonitor-py3:
if (notification === “connected”) {
//Send notification for currentCall module
this.sendNotification(“CALL_CONNECTED”, payload);
//Remove alert only on connect if it is the current alert shown
if (this.activeAlert === payload) {
//Remove alert from UI when call is connected
this.sendNotification("HIDE_ALERT");
this.activeAlert = null;
}
}
but it dosn’t work.
As I already said: I can’t code :-(
Regards,
Carsten
@rkorell
Hi Ralf,
I did not touch the file “fritz_access.py” by now, but what I already did was edeting the files “MMM-FRITZ-Box-Callmonitor-py3.js” and “node-helper.js”.
In the file “node-helper.js” I already added:
const CALL_TYPE = Object.freeze({
INCOMING: “1”,
MISSED: “2”,
OUTGOING: “3”,
BLOCKED: “4”
})
and tried this (now comented out because it did not work):
//Call blocked
//monitor.on(“blocked”, function (call) {
// var name = self.ownNumbers.includes(call.caller) ? self.getName(call.called) : self.getName(call.caller);
// var direction = self.ownNumbers.includes(call.caller) ? “out” : “in”;
// self.sendSocketNotification(“blocked”, { “caller”: name, “direction”: direction });
//});
and this (also now comented out):
for (var index in callArray) {
var call = callArray[index];
var type = call.Type[0];
//Try to handle blocked calls this is new from “if to else” delete all lines from “if to else” if it not works!
//if var name = type == CALL_TYPE.BLOCKED || type == CALL_TYPE.INCOMING ? self.getName(call.Caller[0]) : self.getName(call.Called[0]);
// var duration = call.Duration[0];
// if (type == CALL_TYPE.INCOMING && self.config.deviceFilter && self.config.deviceFilter.indexOf(call.Device[0]) > -1) {
// continue;
//} else
//From here the original script is ongoing
var name = type == CALL_TYPE.MISSED || type == CALL_TYPE.INCOMING ? self.getName(call.Caller[0]) : self.getName(call.Called[0]);
var duration = call.Duration[0];
if (type == CALL_TYPE.INCOMING && self.config.deviceFilter && self.config.deviceFilter.indexOf(call.Device[0]) > -1) {
continue;
}
In the file “MMM-FRITZ-Box-Callmonitor-py3” I did already this:
const CALL_TYPE = Object.freeze({
INCOMING: “1”,
MISSED: “2”,
OUTGOING: “3”,
BLOCKED: “4” //New entry! to handle blocked calls
})
and tried this:
//Handle blocked calls
//if (notification === “blocked”) {
//Send notification for currentCall module
// this.sendNotification(“CALL_BLOCKED”, payload.caller);
//Remove alert from UI when call is connected
// this.sendNotification(“HIDE_ALERT”);
// this.activeAlert = null;
//}
But that all does not work so I comented it out again.
Thats my problem I can’t code and I dont really understand what I’m doing, all I can do is “Try and Error”!
But thanks a lot for your help. :-)
Carsten
Hi Ralf,
I’m glad to read this, I thoght it could only work for me.
I will try to do what you said and edit the READ.ME file to put my changes in to it. I’m sadly could not code, what I did was only compare the different versions and merge the differences in a, for me, logical way together, and surprisingly, it worked.
I personally own a FritzBox 7590AX that distinguishes between 4 types of calls, “incomming, outgoing, missed and blocked”. I would like to have the “blocked” calls also been handled and showed up in the module “MMM-FRITZ-Box-Callmonitor-py3” but I don’t know how to do this. I want these blocked calls handled by the module, because I have a large blocklist of callers that I don’t want to get in touch with. They try to cheat me for mony or peronal data. I got up to 15 calls a day of these unwanted calls.
Do you have any Ideas?
Regards
Carsten
Hi Ralf,
if you search within the MM2 modules for “armybean” and find the module “MMM-Callmonitor-Current-Call” click on the right side in the description on “MMM-FRITZ-Box-Callmonitor”.
On the next screen click on the right side on “25 Forks” there you will find my Fork “xIExodusIx / MMM-FRITZ-Box-Callmonitor-py3”.
You can “git clone it” using “git clone https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git” in the /MagicMirror/modules folder. That should do all for you. After that follow th instrucktions given by “Paviro or Dr.Torchwood” they are almost the same.
I havs only merged the Versions from Paviro and armybeen and drtorchwood together, I did not compile the module new. Paviro did the aase Module, armybean added the (colored) direction arrows and drtorchwood made the module work with python3.
If you wnt to have the colored direction arrows you have to add “showOutgoing: true, and colorEnabled: true,” at the modulesection “MMM-FRITZ-Box-Callmonitor.py” in the /MagicMirror/config/config.js. Same if you use armybeans “MMM-Callmonitor-Current-Call”.
I hope this is understanding for you.
Have fun with it.
Carsten
What have I to do next?
Can I edit my commit? I would like to give mor information and correct some typing errors.
I got it, I made a new “Personal-Access-Token (classic)” giving it write access permissons for repositories and could now successful make “git push”.
Yes, when I type git push, I have to type in my username and next I have to type in the “userpassword” for that I take the “Personal-Access-Toke” I got from github.
Thats what I do:
git push
Username for ‘https://github.com’: xIExodusIx
Password for ‘https://xIExodusIx@github.com’:
remote: Permission to xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git denied to xIExodusIx.
Schwerwiegend: konnte nicht auf ‘https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git/’ zugreifen: The requested URL returned error: 403
The Problem is, that the “password” aka “Personal-Access-Token” is not showed in Linux (RaspiOS). I copy the “PAT (Personal-Access.-Token)” that I stored in Keepass on my PC and insert it using a klick with the right mouse-button in RaspiOS.
git remote -v
origin https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git (fetch)
origin https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git (push)
That is what I get.
Okay I hav now a “Personal-Access-Token” but the next problem is comming up afet I make “git push”
Problem:
remote: Permission to xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git denied to xIExodusIx.
It’s really complicated and frustrating :-(
What have I to do now? I searched for permissons on github to modify for uploading but could not find anything.