MMM-Fuel

sindbad6 · Mar 24, 2017, 6:07 PM

Hi, I made a change in my MM-Fuel.js to implement an additional parameter for shortening the address of a gas station. It is not a big thing, but I would like if it would be integrated in the repository. The point is, I never have done it before. In between I got an account at github, but know? Can somebody give me a link where I can find belonging infos?

strawberry 3.141 · Mar 24, 2017, 6:22 PM

@sindbad6 in short:

fork the repository
make your changes
push them to the fork
create a pull request

sindbad6 · Mar 24, 2017, 7:09 PM

@strawberry-3.141 Ok, I did it now. I’m not sure if I did right. Please inform me if something was wrong. I’m a little bit surprised, to get the possibility to merge my changes.

strawberry 3.141 · Mar 25, 2017, 11:03 AM

@sindbad6 you closed your pull request and deleted the branch so there is no possibility to merge your changes

sindbad6 · Mar 25, 2017, 11:07 AM

@strawberry-3.141 That’s what I was afraid of. I will try to correct it.

strawberry 3.141 · Apr 5, 2017, 11:50 PM

Changelog v1.1.0

API provider development Guide.
API provider spritpreisrechner.at.
Disabled markdownlint rule MD026 (no-trailing-punctuation)
Disabled eslint rule no-console
Documentation
Doclets.io integration
Contributing guidelines
Issue template
Pull request template

[card:fewieden/MMM-Fuel]

Anhalter42 · Apr 6, 2017, 9:39 PM

Anyone considered adding support of multiple locations? Useful for example for commuters to lookup prices at start and destination (and/or somewhere in between) of their daily way to work.

garbleflux · Apr 26, 2017, 6:24 PM

hi strawberry. Absolut nice work, I use it daily! One question: How did you get the in the example (Cheapest Gas Stations) all the text in the listing left justified?

strawberry 3.141 · Apr 26, 2017, 7:57 PM

@garbleflux if you scroll down there is module configuration https://github.com/MichMich/MagicMirror#configuration you can add the class align-left

strawberry 3.141 · Apr 28, 2017, 10:42 AM

Changelog v1.1.1

Disabled markdownlint rule MD024 (no-duplicate-header)
Config option toFixed to show only 2 decimals for the price.
Coordinate.to() throws exception if start point is not set.

Upcoming release v1.2.0
https://github.com/fewieden/MMM-Fuel/projects/1

[card:fewieden/MMM-Fuel]