MMM-Soccer - Standings, Schedules and Top Scorers

Henrik

@fabbr I have modified the module so that it works properly, cycling more than one league. No module-copying necessary. I haven’t made a pull request on github, as suggested by the module author, yet though. I’ll try to do that over Easter.
If you’re really keen, I could just zip my folder with this code change and share it with you for the time being.

fabbr

@Henrik That is so amazing. I love this community. If you won’t mind putting it on a shared folder on dropbox or google drive, just send me link to it and I will check it out. Thanks!

Henrik

@fabbr I’ve sent the details. Note that I did this a couple of months ago and there have been a minor change or two, like updated team logos, to the module since then.

conkhidot

Hey community,

have anyone tried it with the new season 18/19 ?

strawberry 3.141

@conkhidot I just saw that there is now a new api version and the current implementation will not work with the new season :/

fox

From where do i get the ID of Bundesliga 2018 / 2019
i dont understand the content
https://www.football-data.org/documentation/quickstart

evroom

Was looking into that too.
It looks like v1 is not working anymore:

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v1/competitions/'
<html>
<head><title>504 Gateway Time-out</title></head>
<body bgcolor="white">
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.6.2</center>
</body>
</html>

Api v2 does work:

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v2/competitions/'
{"count":145,"filters":{},"competitions":[{"id":2144,"area":{"id":2000,"name":"Afghanistan"},"name":"Playoffs 2/3","code":null,"plan":"TIER_FOUR","currentSeason":{"id":212,"startDate":"2018-05-22","endDate":"2018-05-27","currentMatchday":null},"numberOfAvailableSeasons":1,"lastUpdated":"2018-07-13T13:34:06Z"},{"id":2006,"area":{"id":2001,"name":"Africa"},"name":"WC Qualification","code":null,"plan":"TIER_FOUR","currentSeason":{"id":7,"startDate":"2015-10-07","endDate":"2017-11-14","currentMatchday":6},"numberOfAvailableSea............

German Bundesliga would be id: 2002

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v2/competitions/2002'
{"id":2002,"area":{"id":2088,"name":"Germany"},"name":"Bundesliga","code":null,"plan":"TIER_ONE","currentSeason":{"id":155,"startDate":"2018-08-24","endDate":"2019-05-18","currentMatchday":null},"seasons":[{"id":155,"startDate":"2018-08-24","endDate":"2019-05-18","currentMatchday":null},{"id":3,"startDate":"2017-08-18","endDate":"2018-05-21","currentMatchday":34},{"id":213,"startDate":"2016-08-26","endDate":"2017-05-20","currentMatchday":null},{"id":214,"startDate":"2015-08-14","endDate":"2016-05-14","currentMatchday":null},{"id":215,"startDate":"2013-08-09","endDate":"2014-05-10","currentMatchday":null},{"id":216,"startDate":"2012-08-24","endDate":"2013-05-18","currentMatchday":null},{"id":217,"startDate":"2011-08-05","endDate":"2012-05-05","currentMatchday":null},{"id":218,"startDate":"2010-08-20","endDate":"2011-05-14","currentMatchday":null},{"id":219,"startDate":"2009-08-07","endDate":"2010-05-08","currentMatchday":null},{"id":220,"startDate":"2008-08-15","endDate":"2009-05-23","currentMatchday":null},{"id":221,"startDate":"2007-08-10","endDate":"2008-05-17","currentMatchday":null},{"id":224,"startDate":"2006-08-11","endDate":"2007-05-19","currentMatchday":null},{"id":225,"startDate":"2005-08-05","endDate":"2006-05-13","currentMatchday":null},{"id":226,"startDate":"2004-08-06","endDate":"2005-05-21","currentMatchday":null},{"id":227,"startDate":"2003-08-01","endDate":"2004-05-22","currentMatchday":null},{"id":228,"startDate":"2002-08-09","endDate":"2003-05-24","currentMatchday":null},{"id":229,"startDate":"2001-07-28","endDate":"2002-05-04","currentMatchday":null},{"id":230,"startDate":"2000-08-11","endDate":"2001-05-19","currentMatchday":null},{"id":231,"startDate":"1999-08-13","endDate":"2000-05-20","currentMatchday":null},{"id":232,"startDate":"1998-08-14","endDate":"1999-05-29","currentMatchday":null},{"id":233,"startDate":"1997-08-01","endDate":"1998-05-09","currentMatchday":null},{"id":234,"startDate":"1996-08-16","endDate":"1997-05-31","currentMatchday":null}],"lastUpdated":"2018-06-05T00:10:05Z"}

But unfortunately the v2 commands have a new syntax and probably different output, so the code would need a change.

The changes are probably for the better:
https://www.football-data.org/documentation/api#changelog
but until someone spends some spare-time, we will have to do without it.

fox

@evroom said in MMM-Soccer - Soccer Standings:

Was looking into that too.
It looks like v1 is not working anymore:

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v1/competitions/'
<html>
<head><title>504 Gateway Time-out</title></head>
<body bgcolor="white">
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.6.2</center>
</body>
</html>

Api v2 does work:

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v2/competitions/'
{"count":145,"filters":{},"competitions":[{"id":2144,"area":{"id":2000,"name":"Afghanistan"},"name":"Playoffs 2/3","code":null,"plan":"TIER_FOUR","currentSeason":{"id":212,"startDate":"2018-05-22","endDate":"2018-05-27","currentMatchday":null},"numberOfAvailableSeasons":1,"lastUpdated":"2018-07-13T13:34:06Z"},{"id":2006,"area":{"id":2001,"name":"Africa"},"name":"WC Qualification","code":null,"plan":"TIER_FOUR","currentSeason":{"id":7,"startDate":"2015-10-07","endDate":"2017-11-14","currentMatchday":6},"numberOfAvailableSea............

German Bundesliga would be id: 2002

$ curl -H 'X-Auth-Token:(apikey)' 'http://api.football-data.org/v2/competitions/2002'
{"id":2002,"area":{"id":2088,"name":"Germany"},"name":"Bundesliga","code":null,"plan":"TIER_ONE","currentSeason":{"id":155,"startDate":"2018-08-24","endDate":"2019-05-18","currentMatchday":null},"seasons":[{"id":155,"startDate":"2018-08-24","endDate":"2019-05-18","currentMatchday":null},{"id":3,"startDate":"2017-08-18","endDate":"2018-05-21","currentMatchday":34},{"id":213,"startDate":"2016-08-26","endDate":"2017-05-20","currentMatchday":null},{"id":214,"startDate":"2015-08-14","endDate":"2016-05-14","currentMatchday":null},{"id":215,"startDate":"2013-08-09","endDate":"2014-05-10","currentMatchday":null},{"id":216,"startDate":"2012-08-24","endDate":"2013-05-18","currentMatchday":null},{"id":217,"startDate":"2011-08-05","endDate":"2012-05-05","currentMatchday":null},{"id":218,"startDate":"2010-08-20","endDate":"2011-05-14","currentMatchday":null},{"id":219,"startDate":"2009-08-07","endDate":"2010-05-08","currentMatchday":null},{"id":220,"startDate":"2008-08-15","endDate":"2009-05-23","currentMatchday":null},{"id":221,"startDate":"2007-08-10","endDate":"2008-05-17","currentMatchday":null},{"id":224,"startDate":"2006-08-11","endDate":"2007-05-19","currentMatchday":null},{"id":225,"startDate":"2005-08-05","endDate":"2006-05-13","currentMatchday":null},{"id":226,"startDate":"2004-08-06","endDate":"2005-05-21","currentMatchday":null},{"id":227,"startDate":"2003-08-01","endDate":"2004-05-22","currentMatchday":null},{"id":228,"startDate":"2002-08-09","endDate":"2003-05-24","currentMatchday":null},{"id":229,"startDate":"2001-07-28","endDate":"2002-05-04","currentMatchday":null},{"id":230,"startDate":"2000-08-11","endDate":"2001-05-19","currentMatchday":null},{"id":231,"startDate":"1999-08-13","endDate":"2000-05-20","currentMatchday":null},{"id":232,"startDate":"1998-08-14","endDate":"1999-05-29","currentMatchday":null},{"id":233,"startDate":"1997-08-01","endDate":"1998-05-09","currentMatchday":null},{"id":234,"startDate":"1996-08-16","endDate":"1997-05-31","currentMatchday":null}],"lastUpdated":"2018-06-05T00:10:05Z"}

But unfortunately the v2 commands have a new syntax and probably different output, so the code would need a change.

The changes are probably for the better:
https://www.football-data.org/documentation/api#changelog
but until someone spends some spare-time, we will have to do without it.

Yes that explains a lot. Now i understand that its not working. would be nice if the author would update it.

Mykle1

@fox said in MMM-Soccer - Soccer Standings:

would be nice if the author would update it.

Or, you can fork the repo, make the corrections yourself, and submit a PR to the author. :-)

evroom

Maybe not nice for the author of MMM-Soccer, but I switched to MMM-SoccerLiveScore.
Have to wait for the competition to start to see how it really works, but the matches for August are already displayed.

I modified the api commands in MMM-Soccer to be compliant with v2, but could not get the parsing right.
Am a novice to JavaScript, CSS and JSON, so that was to be expected.

strawberry 3.141

@evroom I would be more than happy, if you could try to investigate your parsing issues. In case I will find some time before my longer holidays in the states, I will try to change the api myself.

evroom

@strawberry-3-141 ,

I will give it a try in the next days. Might have some questions though. As said, I am a novice to JavaScript and JSON, but fit in Perl. For the moment the biggest challenge is to have a programming / test environment setup. MM is running on a Pi and perhaps it is better to have a MM instance running on my MacBook. Or even better, to be able to test the module out of MM, if possible. Will report back asap on my progress, if any.

evroom

It looks like I mixed up things.

You have:
MMM-soccer: uses api.football-data.org - api v1
MagicMirror-FootballLeagues: api.football-data.org - api v1
MMM-SoccerLiveScore: uses www.ta4-images.de

Modules using api.football-data.org - api v1 - are not working and that leaves MMM-SoccerLiveScore as the only module working at this moment.

Now … I promised to have a look at MMM-Soccer, which is MMM-soccer (small detail), to see if I can get v2 working.
So I started with github (never used it before) and got MM working on my MacBook.
Stupidly I got a copy of MMM-SoccerLiveScore and was surprised to see it working.
Only then I realised that my comments were based on MagicMirror-FootballLeagues and not on MMM-Soccer.
Not even speaking about MMM-SoccerLiveScore.

Probably the heat-wave melted my brains, or what was left of it.

What to do ?

On the one hand we have MMM-SoccerLiveScore.
Install it. Configure it. Run it. Go with it.
Nothing needed.
I have it running myself.

Then we have MMM-soccer and MagicMirror-FootballLeagues.
Both need to be adapted to run with api v2.
MagicMirror-FootballLeagues, owner @master117, looks to be more up-to-date and a better start than MMM-soccer.
It says to be a spin.off of MMM-SoccerLiveScore, but I do not know exactly why.
And I do not know if an adapted MagicMirror-FootballLeagues will have more possibilities over the other(s).

I might give it a try, just for the fun of it.

strawberry 3.141

@evroom I never heard of footballleagues.

When I’m correct then soccerlivescroe display the matches and this module display the standings so the modules follow different approaches.

evroom

Both modules display matches and standings.
https://github.com/master117/MagicMirror-FootballLeagues
https://github.com/LukeSkywalker92/MMM-SoccerLiveScore
Differences might be in the extra possibilities of the api and therefore additional possibilities for the module.
For example football-data.org v2 can show you the squad.

strawberry 3.141

I updated the module to work with api v2. One problem that I figured out so far is that the api no longer provides links to the club logos, therefore I added a config option logos to hide them.

It’s under construction and can be tested on the develop branch

git checkout develop

[card:fewieden/MMM-soccer]

evroom

@strawberry-3-141 ,

I have it running. Added “NETHERLANDS”, 2003.

I found out that v1 is still available, but only for pre-World Cup stuff.
But that means you can use v1 for the logos:
http://api.football-data.org/v1/teams/57
http://upload.wikimedia.org/wikipedia/en/5/53/Arsenal_FC.svg

You could add a separate league number_league name_team_logo.json file, with a collection of team logos.
Per league, per team.
Then users can add missing logos themselves and perhaps share their collection with you to be put on github.
Just an idea.

In the meantime I will try to contact the football-data.org person to ask what happened to the logos in v2.

Hope you are not offended when I say that SoccerLiveScore has it all.
Except for 2 things that are unique for your module:
focus and number of teams to show on the table.
Cannot say if the sources of data is equally well maintained, so cannot say if it is worth the trouble of coding, unless it brings you pleasure.

strawberry 3.141

@evroom well we had problems in v1 already that logos were taken down due to copyrights and I sent the api owner updated links, that were never added, so I don’t think that it will come back in v2. For the same reason I also don’t want to host the files on github. I think mostly the german league was the problem, why I added a logic to overwrite broken image links from the api.

It looked like this:

{
		'CLUBNAME': 'https://CLUBLOGO.svg'
    },

if you want to start collecting the logo links in an object where the key is the club name then i can add them to my list. But I don’t have the time to do so myself.

evroom

@strawberry-3-141 ,

Thanks for the background info.
Did not know it was an issue before, but then again I am a novice MM user.

Time and mood is always an issue.
Better for cold evenings or weekends, not when it is 35 degrees and having spent 8 hours behind a PC in a relatively hot office 😀

strawberry 3.141

I just released version 2 of this module

Added

Club logo downloader
New config option logos.
Swedish translations
Documentation
Doclets.io integration
Contributing guidelines
Issue template
Pull request template
Editor config

Changed

Switched from Api v1 to v2.
Updated league ids.
Switched rendering from js to nunjuck template.
Updated travis-ci config.
Disabled markdown lint rules MD024 and MD026

[card:fewieden/MMM-soccer]