fix for black screen in 2.16 and later

[sdetweil]

@np27np27 see this
https://forum.magicmirror.builders/topic/16074/electron-rebuild-and-magicmirror-v2-18-and-more?_=1643636158919

[np27np27]

@sdetweil
Thanks, installed the newer PIR module from @bugsounet and all seems to work fine now. Thanks for the help 👍🏾

[lodevries]

@sdetweil Thank you for your instruction.
One question, my modules are in the directory:
home/pi/MagicMirror/modules/default.
You don’t mention the default subdirectory.
I presume that my path is okay, because all the modules are located in this subdirectory. Is that okay?
Thank you.

[sdetweil]

@lodevries you should never put your extra modules in the default folder, that is reserved for modules MM ships as part of the package

see the ‘How to add modules’ link in my signature below

[sdetweil]

@lodevries you can move the out pretty easily

cd modules/default

mv whatever-name …

then the config.js shoudl change from

“module”: “default/whatever_name”
to
“module”:“whatever-name”

[lodevries]

@sdetweil Thank you.

[captsi]

Thank you so much @sdetweil. I tried to update a module, ran out of memory (8GB SD card install), had to upgrade then got the dreaded black screen. Your first post in this thread solved it.

I’ve written a couple of modules, mainly by using other people’s code as a base and then changing the functionality, only because my coding is basic.

So… one module uses request in the node helper. You’ve already helped someone install it, so thanks for that. The code is
}
request(options, function (error, response, body) {
if (!error && response.statusCode == 200) {
var result = JSON.parse(body)
// console.log(response.statusCode + result); // uncomment to see in terminal
self.sendSocketNotification(‘TIDAL_RESULT’, result)
What should I be using instead of “request”?

Another module I use is calendarweek. Again its broken through the deprecated function “valid url” and “rrule”

createFetcher: function(url, fetchInterval, excludedEvents, maximumEntries, maximumNumberOfDays, auth) {
var self = this;
if (!validUrl.isUri(url)) {
self.sendSocketNotification(“INCORRECT_URL”, {url: url});
return;
}


and

if (typeof event.rrule !== “undefined” && event.rrule !== null && !isFacebookBirthday) {
var rule = event.rrule;
var addedEvents = 0;

					// can cause problems with e.g. birthdays before 1900
					if(rule.options && rule.origOptions && rule.origOptions.dtstart && rule.origOptions.dtstart.getFullYear() < 1900 ||
						rule.options && rule.options.dtstart && rule.options.dtstart.getFullYear() < 1900){
						rule.origOptions.dtstart.setYear(1900);
						rule.options.dtstart.setYear(1900);
					}

					// For recurring events, get the set of start dates that fall within the range
					// of dates we"re looking for.</code>

Is there an elegant solution other than pulling the deprecated libraries?

[sdetweil]

@captsi there is no ‘no work’ solution.

built in fetch replaces request

I don’t know on the others.