MMM-MyScoreboard

[P-Bo726]

Just checking in on my favorite module. Are multiple instances still a possible future enhancement?

[j.e.f.f]

@P-Bo726 Still thinking about the right way to do it. It needs a complete rearchitecture in order to make it happen. And If I’m going to do that, then I also want to rearchitect how I handle the data providers… Instead of a one-to-one relationship between sport and feed, I’d like to be able to take advantage of feeds that can provide multiple sports – e.g.: Using just the ESPN and Sportsnet scoreboard feeds can provide the data for all of the sports I currently support, plus a few more that I haven’t yet integrated. Even better is that Sportsnet gives me all sports it supports at once… so it significantly cuts down on the data pulls.

So it’s a long way of saying yes it’s in in the plan, but it won’t happen overnight.

[nevint]

@j.e.f.f Looking forward to it! I still haven’t got the API key approved, it seems they are ignoring the requests these days.

[j.e.f.f]

@nevint @P-Bo726 Just to give you an update, I have a branch with multiple instances working. Still needs quite a bit of testing, but here’s a sneak peek:

This is three instances of the module running simultaneously, and taking advantage of using feeds that supply scores for multiple sports, including CFL without the API key.

[P-Bo726]

Fantastic. Looks great!

[nevint]

@j.e.f.f Any luck with the CFL testing?

[j.e.f.f]

@nevint going well. I’m going to release it with V2 of the module, which also adds support for multiple instances and takes advantage of using providers for multiple sports. Plus a few new display goodies! I need a few more days of testing, as I’m ironing out some issues with the NBA feed. But otherwise it’s just about ready for release.

[nevint]

@j.e.f.f Awesome!! Thanks for all the hard work!

[j.e.f.f]

I’m excited to announce Version 2.0 of MMM-MyScoreboard! See the top of this thread for all of the new features, or just jump in and get the update.

When updating, be sure to run git pull in the MMM-MyScoreboard directory to get the latest source code, the run npm install to install the new dependencies. Optionally run npm prune to remove old dependencies that are no longer required.

Also note that some of the team short codes have changed, so be sure to check you config against the list of short codes in the README if your team is not showing up.

[P-Bo726]

Thank you for all the hard work.

[emlowe]

Getting some errors using the default config

I’m running node serveronly and I updated to MM 2.1.3

SyntaxError: Unexpected token function
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:542:28)
at Object.Module._extensions…js (module.js:579:10)
at Module.load (/home/elowe/MagicMirror/modules/MMM-MyScoreboard/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Class.loadModuleDefaultConfig (/home/elowe/MagicMirror/modules/MMM-Remote-Control/node_helper.js:254:17)
at /home/elowe/MagicMirror/modules/MMM-Remote-Control/node_helper.js:211:10
at FSReqWrap.oncomplete (fs.js:123:15)

And then :

TypeError: Cannot read property ‘indexOf’ of undefined
at /home/elowe/MagicMirror/modules/MMM-MyScoreboard/providers/ESPN.js:98:34
at Array.filter (native)
at Object.formatScores (/home/elowe/MagicMirror/modules/MMM-MyScoreboard/providers/ESPN.js:97:39)
at /home/elowe/MagicMirror/modules/MMM-MyScoreboard/providers/ESPN.js:75:27
at /home/elowe/MagicMirror/modules/MMM-MyScoreboard/node_modules/json-parse-async/index.js:20:14
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickCallback (internal/process/next_tick.js:104:9)

[j.e.f.f]

@emlowe I haven’t been able to reproduce the first issue you are seeing… still a few things for me to try, so stay tuned.

Meanwhile, I was able to track down the second issue. I published v2.0.1 to address that.

[j.e.f.f]

@emlowe I’ve done more testing on this… still can’t reproduce it.

Can you verify that you ran npm install in the MMM-MyScoreboard directory after you updated to the new version? Dependencies have changed, and MM will throw an error if you haven’t done so.

Here is what I have tried so far, all with MMM-MyScoreboard using the default config:

MM v 2.1.2 normal mode
MM v 2.1.2 server only mode
MM v 2.1.3 normal mode
MM v 2.1.3 server only mode

The error message you’re seeing makes reference to MMM-Remote-Control, so I installed that module then ran the above two 2.1.3 scenarios again, and I didn’t run into the issue.

Interestingly, the error is starting with MMM-Remote-Control’s node_helper module, first on line 211:

self.loadModuleDefaultConfig(currentModule, modulePath);

then on line 254:

var jsfile = require(filename);

I don’t really know how the remote control module works, but it appears to be enumerating the modules to list in its UI, when you can turn them on and off individually. Can you try disabling MMM-Remote-Control temporarily to see if the problem goes away?

[emlowe]

Sorry for the delay in responding. Yes you fixed the one error and the other error is caused by some interaction with MMM-RemoteControl.

Feature Request - I’d like it to say “No Games” or “No Games for selected teams” rather than just not showing anything

Thanks - great module!

[nevint]

Hey there, I just noticed that the times listed for upcoming games appear to be Eastern Time, whilst my MM is showing the time as Mountain Time, which is correct. Any way to change that?

[j.e.f.f]

@nevint The module is supposed to convert the game’s start time to whatever the local time zone is set for the mirror – basically so you know when you will start to see it live. e.g.: If the start time of the feed is 7:00 pm Pacific time, but if your mirror is is set to Eastern time, the mirror will display 10:00 pm as the start time.

Just so I understand what you’re asking, your mirror is displaying the start times as mountain time, but you’d like to see the start times in Eastern Time regardless of what time zone your system is set to? Or are you expecting to see Mountain Time for the start times but instead are seeing Eastern? What time zone is your mirror set to?

[nevint]

@j.e.f.f The mirror is set to MST (the clock module shows the correct time, so I assume it is set to MST!) but the upcoming games display in EST. For instance, the Roughrider game tonight shows a start time of 10pm, but it will start at 8pm MST.

[j.e.f.f]

@nevint ah I see. so the times aren’t being converted as expected… I’ll take a look.

[nevint]

@j.e.f.f Correct sir! Thanks for checking!

[j.e.f.f]

@nevint Tracked it down. It affected all leagues using the using the SNET provider (NFL, MLB, CFL, NHL, MLS). ESPN leagues (NBA, NCAA) were fine. do a git pull and let me know if it fixes the issue for you.