MMM-NOAA - Another Weather Module

[cowboysdude]

I apologize for this… I’m tired and memory is failing but… in the new version we only need a very minimal translation file… the weather will adjust automatically to the language you have selected in your config.js file ;) Here’s an example:

So there’s no need in adding to the translation files :) AND for this:

	curCon.classList.add("xsmall", "bright");
	curCon.innerHTML = this.translate("Currently: ") + current.weather;
	wrapper.appendChild(curCon);

Is correct because the variable current.weather will show in the chosen language all by itself :)

Hang in there I"m trying to finalize what I’m working on now.

[tbbear]

Thanks for the new translations, now only a few topics do not fit for german users.

1. we would not say “Anzahl der Tageslicht” we say “Stunden mit Tageslicht”
2. Not “11 Std. 48 Protokoll” we say “11 Std. 48 min”
3. we dont measure airpressure in “psi” like 29.99 here i also think this is same in a lot of countries our value is “hPa” which means “HectoPascal”
4. in your last post u said that my change is not necessary any more but when i remove it i still get only english actual weather so i keep it

U did and do a great Job and i hope u are not angry about my comments, but i only try to help.
So one last topic:
i saw an issue at github that people have problems installing the module and i think i know why.
If u look at your readme file it lookes like that the apiKey and the airKey are the same keys and thats wrong they are differen keys from different websites. U grab the useAir from “http://api.airvisual.com” so a user has to sign in there and get the airKey from this side but their is no hint in your readme about this.
Hope i could help.

[cowboysdude]

@tbbear NO I appreciate the feedback…I’m using Google translate and I’m sure they are wrong at times :)

I’ll get that corrected! :)

1. we would not say “Anzahl der Tageslicht” we say “Stunden mit Tageslicht” ~ FIXED
2. Not “11 Std. 48 Protokoll” we say “11 Std. 48 min” ~ FIXED
   we dont measure airpressure in “psi” like 29.99 here i also think this is same in a lot of countries our value is “hPa” which means “HectoPascal” ~ Best I can do is to use mb
   in your last post u said that my change is not necessary any more but when i remove it i still get only english actual weather so i keep it ~ Not sure what you mean here…

Updated Readme ;)

[tbbear]

@cowboysdude
So there’s no need in adding to the translation files :) AND for this:

curCon.classList.add("xsmall", "bright");
curCon.innerHTML = this.translate("Currently: ") + current.weather;
wrapper.appendChild(curCon);

Is correct because the variable current.weather will show in the chosen language all by itself :)

this i ment

[cowboysdude]

@tbbear Not sure this looks right to me…

I change this line in my config.js file and get what you’re seeing below
" language: ‘en’," to “language: ‘de’,”

[tbbear]

this looks good see what i get:

[tbbear]

oooo by the way i just see ur change in airpressure wow this is great

[cowboysdude]

@tbbear That I don’t understand… so what I would do … delete the MMM-NOAA directory and do another install like it was new… something is getting crossed up there… you’re missing files. The image I posted is the one that is new on github …

[tbbear]

ok, i will do and report soon thanks

[cowboysdude]

@tbbear Thank you! Glad to help in anyway I can!

[tbbear]

absolutely perfect, readme changed and all other stuff i only see one little topic after i loaded your module it said MMM-NOAA_master so i had to remove the _master all other things are TOP!!! by the way i think u should be the new default weather app im MM

[tbbear]

i know i am the thorn in ur side but i think it would look better if the topic “Stunden mit Tageslicht” would use the same font size as the other lines.

[cowboysdude]

@tbbear said in MMM-NOAA - Another Weather Module:

absolutely perfect, readme changed and all other stuff i only see one little topic after i loaded your module it said MMM-NOAA_master so i had to remove the _master all other things are TOP!!! by the way i think u should be the new default weather app im MM

Yeah that’s what happens when you do a manual install it’s how github sends the file… can’t control that… if you do a git clone that doesn’t happen ;)

[cowboysdude]

@tbbear said in MMM-NOAA - Another Weather Module:

Stunden mit Tageslicht

Perhaps later…right now dinner is calling my name… just got done watching the Cowboys game so food is priority LOL

[tbbear]

of course. enjoy ur meal

[cowboysdude]

@tbbear said in MMM-NOAA - Another Weather Module:

Stunden mit Tageslicht

Where do you see that? I’m looking at it and don’t see it… NOW I’m curious LOL

[cowboysdude]

@tbbear said in MMM-NOAA - Another Weather Module:

absolutely perfect, readme changed and all other stuff i only see one little topic after i loaded your module it said MMM-NOAA_master so i had to remove the _master all other things are TOP!!! by the way i think u should be the new default weather app im MM

Why Thank you… however I don’t think the MM admin feel the same LOL

[tbbear]

u should have dinner not write to me… but is see it on my MM and also on you screenshot that their is a different font size for this

[tbbear]

dont worry he will learn whos module is the best !“!”!"!

[cowboysdude]

I’m good :) That’s odd… what do you have in your custom.css file?