MMM-Fuel

ostfilinchen

Hi @strawberry-3-141 ,

is it possible, to implement an delay so that i can start this module 2 time with different sorts? Otherwise can u implement more then 1 fuel sort?

Regards
Daniel

strawberry 3.141

@ostfilinchen will look into this

ostfilinchen

@strawberry-3-141: i’ve made changes in MMM-Fuel.js, node_helper.js, de.json and en.json. Now it works as it should.
The Parameter ‘type’ in the config.js must be now an array.

How can i send you these files, so that u can implement in the original files?

strawberry 3.141

@ostfilinchen create a pull request on github or upload the files as zip

ostfilinchen

@strawberry-3-141 i’ve open an issue on github

strawberry 3.141

Changelog:

It’s now possible to show

multiple fuel types at once
whether the gas station is open or closed

Have a look on the new config options: types, sortBy and open

Deprecated config options: type

Shootout to @ostfilinchen who did the prework for it

alt text

[card:fewieden/MMM-Fuel]

yawns

wow, nice improvement!

ostfilinchen

Hi @strawberry-3-141,

can u insert the open-Parameter to the readme on github?

Daniel

strawberry 3.141

@ostfilinchen it’s done must have forgot that one

FlorianRD

I didn’t need the “rotate Intervall”. Just sort by price (lower Price first).
How to modified the Settings for this result? Thanks

lolobyte

Hi, great job.
How to deactivate toggeling “rotateInterval:”

ostfilinchen

At the Moment there’s no Option to disable the rotate-feature.

U can open an issue on github to ask, if he can create this option.

lolobyte

@ostfilinchen Thank you, erledigt! ;-)

strawberry 3.141

@lolobyte done

lolobyte

@strawberry-3.141 thank you.
Very fast reaktion.
It works.

ostfilinchen

Hi @strawberry-3-141. I have an Issue with this module. My Mirror shows me no gasprice list. I wonder about it and so i check logfiles and so on. I also rebuild the string that get the request from tankerkoenig.de. The Response says: API-KEY blocked. Please contact tankerkoenig.de.

On the website of tankekoenig u can download a logfile from our api-key. here i saw, that tankerkoenig get very often gets an request.

[code]
IP-ADDRESS - - [25/Nov/2016:06:28:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.008
IP-ADDRESS - - [25/Nov/2016:06:29:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:29:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:30:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.009
IP-ADDRESS - - [25/Nov/2016:06:31:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.014
IP-ADDRESS - - [25/Nov/2016:06:33:08 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.012
IP-ADDRESS - - [25/Nov/2016:06:34:04 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.015
IP-ADDRESS - - [25/Nov/2016:06:34:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:34:46 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:35:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:36:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:36:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:36:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.009
IP-ADDRESS - - [25/Nov/2016:06:37:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.008
IP-ADDRESS - - [25/Nov/2016:06:37:37 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:39:05 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.020
IP-ADDRESS - - [25/Nov/2016:06:39:18 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.021
IP-ADDRESS - - [25/Nov/2016:06:39:24 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:43:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:44:51 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.028
IP-ADDRESS - - [25/Nov/2016:06:44:51 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.032
IP-ADDRESS - - [25/Nov/2016:06:45:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:46:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:48:08 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:49:04 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:49:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.010
IP-ADDRESS - - [25/Nov/2016:06:49:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:50:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.018
IP-ADDRESS - - [25/Nov/2016:06:51:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.027
IP-ADDRESS - - [25/Nov/2016:06:51:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.031
IP-ADDRESS - - [25/Nov/2016:06:51:53 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:52:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:52:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:54:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.015
IP-ADDRESS - - [25/Nov/2016:06:54:18 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.014
IP-ADDRESS - - [25/Nov/2016:06:54:25 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:58:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:59:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104
[/code]

Can u please look in the code whats going wrong?

Regards
Daniel

strawberry 3.141

@ostfilinchen did you may test something on your mirror and restarted it every time? can you post your config part of mmm-fuel?

ostfilinchen

no, i don’t restart the mirror.

here is the part of the config:

	{
	module: "MMM-Fuel",
	position: "top_center",
	config: {
		api_key: "API-KEY",
		lat: 51.282854,
		lng: 14.109648,
		types: ["e5","diesel"],
		sortBy: "e5",
		open: true,
		radius: 16,
		max: 3
			}
	},

strawberry 3.141

i will check it this afternoon

strawberry 3.141

@ostfilinchen i tested some stuff and the only thing which forced the module to refresh data more often then it was defined in the config was by restarting the mirror what you said was not your case and accessing the mirror with a browser via another computer. everytime you refresh that page it will load the data.

@lolobyte your issue in github is resolved now

if there is one fuel type present in config and thie price is 0€ the gas station gets completely removed from the display

if there is more than one fuel type in config and one of them has a price greater than 0€ the gas station will be displayed at the end of the list, otherwise the gas stations is also removed from the list

[card:fewieden/MMM-Fuel]