@schris88

It is working now.
I see it displayed on the MagicMirror.
Due to no sunshine I cannot check actual values, but that is for later.

@schris88

Hi there,

I am using hoymiles-wifi myself and am curious on how it looks on the MagicMirror.
Very nice initiative !!

Trying to get your module working, but no luck till now.
I will open some Issues for you to have a look at.

Best regards,

E.J.

@sdetweil

My Google Calendar remark was more aimed at the basic.ics we get from it.
I see now it added an unnecessary discussion.
However it did take me some time to find out that the screen you showed is only seen after clicking the More Options button; my bad.

Your evaluation of showEnd and showEndsOnlyWithDuration is quite useful.

Btw, one time in the Dutch parliament there was a big confusion about voting for something.
If you do not want XXX, then vote yes, if you want XXX then vote no.
Of course this went wrong.

Concluding: all my tests passed, meaning it works as designed.
I will raise an issue for a feature request, but you can either reject it or put it on the bottom of your list of todo’s.

@sdetweil said in Cant use showEnd icloud cal:

@evroom I just posted an update to fix showEndsOnlyWithDuration

Okay, so to recap (me talking to myself :-)):
It basically applies to a fullday event that spans multiple days.
Because a single fullday event has an equal start and end date.
And a fullday reoccurring event is just X times a single fullday event.

Google Calendar makes it a bit more difficult to understand the begin and end dates (hence the need to calculate and adjust) :

TestCal: SINGLE_FULLDAY_EVENT
Thursday, October 31

BEGIN:VEVENT
DTSTART;VALUE=DATE:20241031
DTEND;VALUE=DATE:20241101

TestCal: FULLDAY_EVENT_SPANS_3_DAYS
November 1 – 3, 2024

DTSTART;VALUE=DATE:20241101
DTEND;VALUE=DATE:20241104

Here a fullday event that spans multiple days:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20241101
DTEND;VALUE=DATE:20241104
DTSTAMP:20241026T152207Z
UID:2srults5ctu7t3n4piick00gv8@google.com
CREATED:20241026T152154Z
LAST-MODIFIED:20241026T152154Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: FULLDAY_EVENT_SPANS_3_DAYS
TRANSP:TRANSPARENT
END:VEVENT

‘prevent’ means: when set to false (default), you will see the end date.
When set to true, you will not see the end date.

Test with latest updates (git pull on Sat 26 Oct 16:51:00 CEST 2024):

showEnd: true.
showEndsOnlyWithDuration: false,

!

showEnd: true.
showEndsOnlyWithDuration: true,

!

@evroom said in Cant use showEnd icloud cal:

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

Opened:
https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues/266

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

@sdetweil

Sam,

Whilst testing your last changes, I sort of see a need for a new date format parameter.
For an event with duration, spanning multiple days.
E.g. spanningDayEventDateFormat.

[TestCal: TIMESPAN_HOLIDAY]

BEGIN:VEVENT
DTSTART:20241125T110000Z
DTEND:20241127T160000Z
DTSTAMP:20241026T091719Z
UID:1lk06o70p9bp21ln3pdfda4ng0@google.com
CREATED:20241026T090035Z
LAST-MODIFIED:20241026T090035Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: TIMESPAN_HOLIDAY
TRANSP:OPAQUE
END:VEVENT

For events with duration. spanning one night, like an overnight flight, it is not really necessary, but not really bad either.

[TestCal: OVERNIGHT_FLIGH]

BEGIN:VEVENT
DTSTART:20241202T190000Z
DTEND:20241203T030000Z
DTSTAMP:20241026T091719Z
UID:0s4flhmaf7p6q5atemshns4upp@google.com
CREATED:20241026T090148Z
LAST-MODIFIED:20241026T090215Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: OVERNIGHT_FLIGHT
TRANSP:OPAQUE
END:VEVENT

The reasoning behind it is following:
For a ‘normal’, single, event I am not really interested in the full end date format (dateEndFormat).
That is why I normally use dateEndFormat: "HH:mm".
But for an event with duration, spanning multiple days, the setting dateEndFormat: "ddd MMM D - HH:mm" makes more sense.

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[good for normal events, ‘bad’ for spanning events]:

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “ddd MMM D - HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[‘bad’ for normal events, good for spanning events]:

I hope I could explain it well enough.
And that it makes sense. :-)

Best regards,

E.J.

@sdetweil

Sam,

The option showEndsOnlyWithDuration is not described yet on https://docs.magicmirror.builders/modules/calendar.html.

The interaction / dependancy with showEnd also needs to be documented.

I do not know if documentation issues also can / should be done on https://github.com/MagicMirrorOrg/MagicMirror.

@sdetweil

Will follow up in the “Cant use showEnd icloud cal” topic then.

@sdetweil

Sorry, do not want to cause confusion.
One should probably not do a quick test right after a full working day:-)
The number of test cases seems endless.

Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?

@sdetweil

Just to follow up on the test I did where I got the end date displayed according to ‘dateEndFormat’ for a repeating allday event.
Most of it is also covered in the other thread.

It is working with your suggested change in calendar.js.
No need to set ‘showEnd: false’.

urgency: 0,
timeFormat: "absolute",
dateFormat: "dddd MMM D - HH:mm",
dateEndFormat: "dddd MMM D - HH:mm",
fullDayEventDateFormat: "dddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
getRelative: 0,

@sdetweil

In short, I think it is looking better now.
To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.
The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.
In my examples I only see a change when I toggle ‘showEnd’.

urgency: 0,
timeFormat: "absolute",
dateFormat: "dddd MMM D - HH:mm",
dateEndFormat: "HH:mm",
fullDayEventDateFormat: "dddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
getRelative: 0,

showEnd: true,
showEndsOnlyWithDuration: false,

showEnd: false,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: false,

@sdetweil said in Cant use showEnd icloud cal:

calendar.js

~/MagicMirror/modules/default/calendar/calendar.js

this.config.fullDayEventDateFormat

showEnd: true,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: true,

@sdetweil

Repeating all day event with X occurrences shows end time of 23:59.

urgency: 0,
timeFormat: "absolute",
dateFormat: "dddd MMM D - HH:mm",
dateEndFormat: "HH:mm",
fullDayEventDateFormat: "dddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
getRelative: 0,

BEGIN:VEVENT
DTSTART;VALUE=DATE:20241104
DTEND;VALUE=DATE:20241107
DTSTAMP:20241023T164753Z
UID:086ujg156a8n9t0dpg8h3g4ptu@google.com
CREATED:20241023T164710Z
LAST-MODIFIED:20241023T164710Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: ALLDAY_REPEAT_FROM_TO
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT
DTSTART;VALUE=DATE:20241111
DTEND;VALUE=DATE:20241112
RRULE:FREQ=DAILY;COUNT=3
DTSTAMP:20241023T164753Z
UID:0c9ah6plfonal1s1250k2mmgbt@google.com
CREATED:20241023T164743Z
LAST-MODIFIED:20241023T164743Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: ALLDAY_REPEAT_3_OCCURENCES
TRANSP:TRANSPARENT
END:VEVENT

(cannot upload a text file anymore, only images)

Changed:

dateEndFormat: "dddd MMM D - HH:mm",

Changed:

showEnd: false,

@sdetweil

At first sight I do not like it too much.
Daily repeating events have an end time now that does not make really sense (23:59) and the Holliday end time only makes sense when the dateEndFormat is extended to see the date.
And that makes it pretty crowded in the date/time column.

IMHO :-)

timeFormat: "absolute",
showEnd: true,
showEndsOnlyWithDuration: true,
//dateEndFormat: "HH:mm",
dateEndFormat: "dddd MMM D - HH:mm",

I currently have
showEndsOnlyWithDuration: true,
but
showEndsOnlyWithDuration: false,
does not seem to do anything.

timeFormat: "absolute",
showEnd: false,
showEndsOnlyWithDuration: true,
dateEndFormat: "HH:mm",
//dateEndFormat: "dddd MMM D - HH:mm",

Regards,

E.J.

@capedbuffethero
Hi there,

Concerning pip you will need to find out what is calling it.
Normally it is not a daemon process, meaning something else is calling it.

Can you get the following output:

ps aux | grep pip

And then using the lowest PID found:

pstree -a <PID>

You can find the lowest PID using:

ps aux | grep pid | awk '{print $2}' | sort -u

You can also check if there is a cronjob running that is calling pip:

crontab -l | egrep 'pip|python'

From there we can Google ourselves to a solution :-)

Best regards,

E.J.

This event:

BEGIN:VEVENT
DTSTART;TZID=Europe/Berlin:20240104T180000
DTEND;TZID=Europe/Berlin:20240104T200000
RRULE:FREQ=WEEKLY;WKST=MO;COUNT=10;BYDAY=TH
DTSTAMP:20240102T212443Z
UID:63c23cpe0h356vgjl0o4tsnjbi@google.com
CREATED:20240102T212139Z
LAST-MODIFIED:20240102T212139Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:#:SingleEventRepeating
TRANSP:OPAQUE
END:VEVENT

Leads to this:

0|MagicMirror  | [02.01.2024 22:22.25.197] [DEBUG] Title: #:SingleEventRepeating, with dates: ["2024-01-04T17:00:00.000Z","2024-01-11T17:00:00.000Z",null,null,"2024-02-01T17:00:00.000Z","2024-02-08T17:00:00.000Z",null,null,null,"2024-03-07T17:00:00.000Z"]
0|MagicMirror  | [02.01.2024 22:22.25.197] [DEBUG] event.recurrences: undefined

So:

[
    "2024-01-04T17:00:00.000Z",
    "2024-01-11T17:00:00.000Z",
    null,
    null,
    "2024-02-01T17:00:00.000Z",
    "2024-02-08T17:00:00.000Z",
    null,
    null,
    null,
    "2024-03-07T17:00:00.000Z"
]

Resulting in MM showing only 5 of the 10 events.

I would like to know where to look for the RRULE processing; cannot find anything in the calendar code.
As there are some other issues that I found, I could perhaps learn something from it.

Otherwise I will open an issue for it.

@sdetweil

I applied your fixed calendarutils.js and ical.js files and it works like a charm now.
Many thanks for solving this, very much appreciated !!

E.J.

Sam,

Thanks a lot for diving into this.
I had massive Internet problems the last 4 weeks and could not get to it myself.

I am happy to modify a file or two to see if your fix works.
Just send me the filename(s) and what to modify and I will test it.

Btw, the Internet problems showed that when the calendar module cannot connect for some time, it just gives up and stalls.
When Internet is present again it does not try to connect again or does not put an effort to get calendar data (ics file).
But that is another topic.

Greetings,

E.J.

Hi,

I have an issue with the calendar module that occurs when you move an Allday event.
It can be recreated.
Perhaps someone has an idea where it goes wrong ?

Scenario:

Added an event ‘ThirdAllday event (date, repeating weekly)’, starting Nov 01.

–> On MMM: event seen on all Tuesdays, including this event on Tuesday Nov 08.

Moved one ‘ThirdAllday event (date, repeating weekly)’ event from Tuesday Nov 08 to Wednesday Nov 09.
Used click and drag.
‘Edit recurring event: This event’

On Google Calendar:

events seen on all Tuesdays, except the moved event (correct)
moved event not on Tuesday Nov 08 (correct).
moved event on Wednesday Nov 09 (correct).

On MMM:
events seen on all Tuesdays, including the moved event (false)
still the moved event on Tuesday Nov 08 (false).
NO moved event on Wednesday Nov 09 (false).

basic.ics on event creation:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20221101
DTEND;VALUE=DATE:20221102
RRULE:FREQ=WEEKLY;BYDAY=TU
DTSTAMP:20221026T100527Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
CREATED:20221026T100523Z
LAST-MODIFIED:20221026T100523Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT

basic.ics after moving 1 event:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20221109
DTEND;VALUE=DATE:20221110
DTSTAMP:20221026T100622Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
RECURRENCE-ID;VALUE=DATE:20221108
CREATED:20221026T100523Z
DESCRIPTION:
LAST-MODIFIED:20221026T100610Z
LOCATION:
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT

DTSTART;VALUE=DATE:20221101
DTEND;VALUE=DATE:20221102
RRULE:FREQ=WEEKLY;BYDAY=TU
DTSTAMP:20221026T100622Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
CREATED:20221026T100523Z
LAST-MODIFIED:20221026T100523Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT