• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-Gas

Scheduled Pinned Locked Moved Transport
56 Posts 13 Posters 24.8k Views 12 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • M Offline
    mochman Module Developer @3d
    last edited by mochman Sep 30, 2018, 4:40 PM Sep 30, 2018, 4:38 PM

    @3d Hmm, the code is supposed to use that variable as an integer. What kind of error were you getting when you had items: 10,?

    Edit: Guess it doesn’t matter. Math.min() still works using a string.

    3 1 Reply Last reply Sep 30, 2018, 8:11 PM Reply Quote 1
    • 3 Offline
      3d @mochman
      last edited by Sep 30, 2018, 8:11 PM

      @mochman It wasn’t loading the config.js. So I just stepped through line by line until if failed. Once if failed I put the 10 in quotations and it loaded.

      1 Reply Last reply Reply Quote 0
      • J Offline
        justjim1220 Module Developer
        last edited by Oct 1, 2018, 12:02 AM

        Ok, so I deleted my current GAS module. and reinstalled it.

        I went to the website to check my zip code, which is good.

        I tried it with & without the quotes around the 10.

        Still not working for me… :slightly_frowning_face:

        "Life's Too Short To Dance With Ugly People"
        Jim Hallock - 1995

        1 Reply Last reply Reply Quote 0
        • J Offline
          justjim1220 Module Developer
          last edited by Oct 1, 2018, 12:31 AM

          NVM!!!

          When in doubt, Reboot it out!!!

          :smiling_face_with_sunglasses:

          "Life's Too Short To Dance With Ugly People"
          Jim Hallock - 1995

          1 Reply Last reply Reply Quote 0
          • R Offline
            rob73
            last edited by Oct 3, 2018, 1:37 PM

            Is there any way to remove the Distance column? I live in a small town and dont really need the distances on the display. I hunted around the files a little bit and didnt see anything that I could maybe edit or delete that would remove it.

            Rob

            1 Reply Last reply Reply Quote 0
            • M Offline
              mochman Module Developer
              last edited by mochman Oct 4, 2018, 7:47 PM Oct 4, 2018, 7:45 PM

              @rob73 I haven’t tried this to see how it looks, but you may just be able to comment out a few of the lines in MMM-Gas.js
              Try commenting out the last 2 lines of this code in the getDom() function.

               var td5 = document.createElement("td");
               td5.innerHTML = dist;
               TDrow.appendChild(td5);
               weatherTable.appendChild(TDrow);
              

              It should look like this when you’re done.

              var td5 = document.createElement("td");
              td5.innerHTML = dist;
              //TDrow.appendChild(td5);
              //weatherTable.appendChild(TDrow);
              

              You should also comment out this part as well.

              var bjumpy = document.createElement("th");
              bjumpy.setAttribute("style", "text-align:center");
              bjumpy.classList.add("xsmall");
              bjumpy.innerHTML = "Distance";
              //xFCRow.appendChild(bjumpy);
              //weatherTable.appendChild(xFCRow);
              
              R 1 Reply Last reply Oct 5, 2018, 5:35 PM Reply Quote 1
              • R Offline
                rob73 @mochman
                last edited by Oct 5, 2018, 5:35 PM

                @mochman … Awesome… I followed your instructions and it worked! Thank you! I would have never figured that out on my own…

                Thanks again!

                Rob

                1 Reply Last reply Reply Quote 1
                • C Offline
                  cowboysdude Module Developer
                  last edited by cowboysdude Oct 6, 2018, 2:51 PM Oct 5, 2018, 9:21 PM

                  New config option to hide or show distance column.

                  example config:

                  {
                            disabled: false,
                            module: "MMM-Gas",
                            position: "top_left",
                            config: {
                               zip: "14904",
                               items: 10,
                               typeGas: "",	//premium, mid-grade, diesel, or blank for regular
                               sortBy: "price", 	//distance, price
                         distance: false //default is true, so using true just don't use distance in your config
                    		}			   
                        },
                  

                  DO a git pull in the MagicMirror/modules/MMM-Gas dir to update!

                  AND a HUGE Thanks to @mochman for all the help!!!

                  M 1 Reply Last reply Oct 6, 2018, 12:58 AM Reply Quote 2
                  • M Offline
                    Mykle1 Project Sponsor Module Developer @cowboysdude
                    last edited by Oct 6, 2018, 12:58 AM

                    @cowboysdude

                    Thanks. I really like this module alot. Very nice options and I love the mouse overs. Fantastic work! :thumbsup:

                    0_1538787518808_gasas.png

                    Create a working config
                    How to add modules

                    1 Reply Last reply Reply Quote 2
                    • R Offline
                      rob73
                      last edited by Oct 8, 2018, 3:30 AM

                      Awesome!

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 3 / 6
                      3 / 6
                      • First post
                        21/56
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy