MMM-Gas

[cowboysdude]

Yes they’ve changed their page so the data it’s asking for is incorrect. I will fix it when I can get some time to do it… Sorry everyone.

[mochman]

@cowboysdude I just sent you a pull request that should fix their new page.

[cowboysdude]

@mochman said in MMM-Gas:

@cowboysdude I just sent you a pull request that should fix their new page.

I got it and it’s been merged!! HUGE Thank you for fixing this…time is killing me right now :)

"You can now get fuel data for regular (default), mid-grade, premium, and diesel. I also threw in a way to sort by price or distance (default). I saw you had an items variable in the default config section as well. I assume that was to only show X number of items. I added that to your for loop that iterates through the gas array. "

He not only fixed it but enhanced it to make it 100% even better! Here’s an example config:

          disabled: false,
          module: "MMM-Gas",
          position: "top_left",
          config: {
             zip: "14904",
             items: 10,
             typeGas: "",	//premium, mid-grade, diesel, or blank for regular
             sortBy: "price" 	//distance, price
  		}			   
      }, 

See the // notes for added features! Thank you again @mochman

Do a git pull to update and update your config accordingly :)

[Mykle1]

@mochman said in MMM-Gas:

I just sent you a pull request that should fix their new page.

Well done, sir! Well done!

[3d]

@cowboysdude and @mochman … WOW, nice work!

The only thing I had to fix was put the ITEMS in quotes…the proper syntax for me was:

items: "10",

[mochman]

@3d Hmm, the code is supposed to use that variable as an integer. What kind of error were you getting when you had items: 10,?

Edit: Guess it doesn’t matter. Math.min() still works using a string.

[3d]

@mochman It wasn’t loading the config.js. So I just stepped through line by line until if failed. Once if failed I put the 10 in quotations and it loaded.

[justjim1220]

Ok, so I deleted my current GAS module. and reinstalled it.

I went to the website to check my zip code, which is good.

I tried it with & without the quotes around the 10.

Still not working for me… :slightly_frowning_face:

[justjim1220]

NVM!!!

When in doubt, Reboot it out!!!

:smiling_face_with_sunglasses:

[rob73]

Is there any way to remove the Distance column? I live in a small town and dont really need the distances on the display. I hunted around the files a little bit and didnt see anything that I could maybe edit or delete that would remove it.

Rob

[mochman]

@rob73 I haven’t tried this to see how it looks, but you may just be able to comment out a few of the lines in MMM-Gas.js
Try commenting out the last 2 lines of this code in the getDom() function.

 var td5 = document.createElement("td");
 td5.innerHTML = dist;
 TDrow.appendChild(td5);
 weatherTable.appendChild(TDrow);

It should look like this when you’re done.

var td5 = document.createElement("td");
td5.innerHTML = dist;
//TDrow.appendChild(td5);
//weatherTable.appendChild(TDrow);

You should also comment out this part as well.

var bjumpy = document.createElement("th");
bjumpy.setAttribute("style", "text-align:center");
bjumpy.classList.add("xsmall");
bjumpy.innerHTML = "Distance";
//xFCRow.appendChild(bjumpy);
//weatherTable.appendChild(xFCRow);

[rob73]

@mochman … Awesome… I followed your instructions and it worked! Thank you! I would have never figured that out on my own…

Thanks again!

Rob

[cowboysdude]

New config option to hide or show distance column.

example config:

{
          disabled: false,
          module: "MMM-Gas",
          position: "top_left",
          config: {
             zip: "14904",
             items: 10,
             typeGas: "",	//premium, mid-grade, diesel, or blank for regular
             sortBy: "price", 	//distance, price
       distance: false //default is true, so using true just don't use distance in your config
  		}			   
      },

DO a git pull in the MagicMirror/modules/MMM-Gas dir to update!

AND a HUGE Thanks to @mochman for all the help!!!

[Mykle1]

@cowboysdude

Thanks. I really like this module alot. Very nice options and I love the mouse overs. Fantastic work! :thumbsup:

[rob73]

Awesome!

[richland007]

Is this still working?? It was working flawlessly for me before but i turned the MM off for like 3 months when i was doing some work around the house and when i turned it back on i do not see anything on my list of gas stations.

It just says updated at this time and date but nothing listed.
I did a git pull thinking that something might have been updated in those 3 months but nothing changed.

Anyone else experiencing difficulties ???

D

[Mykle1]

@richland007 said in MMM-Gas:

Anyone else experiencing difficulties ???

I just did a git pull on my current installation and everything seems to be working just fine.

Have you made any modifications? Are there any errors being reported in the terminal or dev console?

[cowboysdude]

@richland007 Do a git pull as things did change and I updated it a month ago or so.

[richland007]

I did a git pull and than an npm install insde the module but still no luck only updated on today’s date and time.
No list of gas stations nothing just that.

Do we have to change anything in the module settings on the config.js file for the update??

Denis

[Mykle1]

@richland007

This should be your config entry. Have you tried another zip code? See if this one works.

{
            disabled: false,
            module: "MMM-Gas",
            position: "top center",
            config: {
                zip: "10306"
            }
        },