new update/upgrade script, ready for testing

sdetweil

@spitzlbergerj no attachment… send via mail… same ID as here on gmail

evroom

@sdetweil said in new update/upgrade script, ready for testing:

I changed test script to do it your way… try it out

pi@raspberrypi:~/MagicMirror $ curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash
On branch master
Your branch is up to date with 'origin/master'.

Sam. I think the issue is, that the command is git status and you alias LC_ALL=C git to the name git, not the command git.
You cannot use the alias as a replacement for a part of your command, but I might be wrong.

I think the only solution is to check for language en_US and then for every git command either use plain git or else by using LC_ALL=C.

Or just use LC_ALL=C for every git call.

sdetweil

@evroom

name git, not the command git

i don’t understand this…

its been working fine for quite a few months, handling LC_ALL and LANGUAGE, just hs system has LANG too…

anyhow, alias is supposed to work on ‘commands’ issued, and replace the started command with the replacement string (once)

this is how the git doc suggested dealing with this issue and stackexchange posts over quite some time echoed it…

I changes to the ‘LC_ALL=C git’ approach anyhow

I don’t even check now, just do it… on english system, it doesn’t hurt

spitzlbergerj

no, I didn’t say I was on 2.10.

i have now run the script in apply mode. The output is very long and apparently it was not updated, right?

Link Text

Sorry, I’ve always done the update via git. Now I am confused …

sdetweil

@spitzlbergerj yes, please erase this file

~/MagicMirror/installers/dumpactivemodules.js

it was copied early by the official updater in error

evroom

@sdetweil

It is always difficult creating something and having it run flawlessly on many different systems with their many different settings, some exotic :-)

One more thing I stumbled upon when googling:

shopt -s expand_aliases

Add this before the alias command, or just at the top of your script.
Seems to work.

spitzlbergerj

@sdetweil
OK, now I have another problem :disappointed_face: . The upgrade script ran and I think it upgraded some stuff.

At some point, I must have gotten my permissions mixed up. There were a number of directories that were root:root. Here there was Permission denied.

I have now corrected the owners. But now the upgrade script doesn’t run anymore, because it assumes that I am already on 2.10.

Can I force another upgrade?

sdetweil

@spitzlbergerj yes, change ‘apply’ to ‘force’

sdetweil

@evroom I decided to forget about alias altogether…

evroom

@sdetweil said in new update/upgrade script, ready for testing:

I decided to forget about alias altogether…

Of course, your script, your call.
Just keep it somewhere in the back of your head, should you stumble over it again in any way or form.
As I minimum I learned something new, including using alias in a script at all.

Thanks for the scripts and the help you provide to all users with fresh install and / or upgrade issues, including myself.

sdetweil

@evroom thanks for your help… I had learned about the shell options to expand aliases about 10 yrs ago, and forgot… my systems all run with it on.

spitzlbergerj

@sdetweil
now it worked, my MagicMirror is on the current version :smiling_face_with_open_mouth_smiling_eyes: :thumbs_up: .

Many, many thanks for your patient help. It was a somewhat more difficult birth. But the end is good and so everything

I have a lot of respect for you, who created such a complex script and patiently provides support. Thank you very much!

One last question:
During the update there was another message:

npm WARN deprecated @types/vfile-message@2.0.0: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.

Is there anything else I should do?

sdetweil

@spitzlbergerj said in new update/upgrade script, ready for testing:

It was a somewhat more difficult birth. But the end is good

yes, sadly we tested for a few months and this didn’t happen… weird…

on the warnings… really nothing u can do as a user… the code author should update
but hasn’t…

spitzlbergerj

@sdetweil thank you very much again!

hoogveld

After wrecking my MM installation after the second last update I used this script. It worked fine for me!!!

Thanks for all your work!

Mykle1

Pi4 - 4Gb = Worked flawlessly. January 12, 2020 @ 2020 hours. NYC - USA

Tigershroffr

kindly also mention on which part and module you have update the script

sdetweil

@Tigershroffr sorry. Not quite sure what u are asking

BKeyport

Update script not working for MMM-CalendarExt2 update. Is it me or you?

Test run using:

bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)"

seems to walk through modules correctly. Live run

bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)" apply

does not.

Upgrade started - Tue Jan 28 14:25:31 PST 2020
system is Linux pihole 4.19.75-v7l+ #1270 SMP Tue Sep 24 18:51:41 BST 2019 armv7l GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 10 (buster) Release: 10 Codename: buster
doing test run = true

saving custom.css
remote name = origin
upgrading from version 2.10.1 to 2.10.1
fetching latest revisions
git fetch rc=0
current branch = master
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   package-lock.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	0
	css/save_custom.css

no changes added to commit (use "git add" and/or "git commit -a")
there are 1 local files that are different than the master repo

   package-lock.json

save/restore files selection = n
restoring package-lock.json from repo
skipping restore for package-lock.json, doing test run
test merge result rc='' , if empty, no conflicts
skipping merge, only test run

processing dependency changes for active modules with package.json files
processing for module MMM-CalendarExt2 please wait
----------------------------------
skipped processing for MMM-CalendarExt2, doing test run
processing complete for module MMM-CalendarExt2
processing for module MMM-DarkSkyForecast please wait
----------------------------------
skipped processing for MMM-DarkSkyForecast, doing test run
processing complete for module MMM-DarkSkyForecast
processing for module MMM-DHT-Sensor please wait
----------------------------------
skipped processing for MMM-DHT-Sensor, doing test run
processing complete for module MMM-DHT-Sensor
processing for module MMM-RTSPStream please wait
----------------------------------
skipped processing for MMM-RTSPStream, doing test run
processing complete for module MMM-RTSPStream
processing for module MMM-Remote-Control please wait
----------------------------------
skipped processing for MMM-Remote-Control, doing test run
processing complete for module MMM-Remote-Control
restoring custom.css
removing git alias
Upgrade ended - Tue Jan 28 14:25:40 PST 2020

Upgrade started - Tue Jan 28 14:25:46 PST 2020
system is Linux pihole 4.19.75-v7l+ #1270 SMP Tue Sep 24 18:51:41 BST 2019 armv7l GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 10 (buster) Release: 10 Codename: buster
user requested to apply changes
doing test run = false

saving custom.css
remote name = origin
local version 2.10.1 already same as master 2.10.1
restoring custom.css
removing git alias
Upgrade ended - Tue Jan 28 14:25:47 PST 2020

screen on live run is:

the log will be /home/pi/MagicMirror/installers/upgrade.log
No LSB modules are available.
doing test run = false
update log will be in /home/pi/MagicMirror/installers/upgrade.log

saving custom.css
local version 2.10.1 already same as master 2.10.1
restoring custom.css

sdetweil

@BKeyport gotta be me… I will look at in about 45 minutes, when I get home.

Thx for the report