With a https address the module works on my system with MM v2.30.0 and v2.31.0. Does it work if you use a https address instead a rtsp one?

Like this:

url: ["https://www.openstreetmap.org/export/embed.html?bbox=-151.34765625000003%2C-39.77476948529546%2C142.20703125000003%2C75.00494000767517&layer=mapnik"],

@p1lspeda said in MMM-PublicTransportHafas - Error when loading - DeparturFetcher.mjs:

### VERSIONS: electron: 32.2.7; used node: 22.14.0; installed node: 22.14.0; npm: 10.9.2; pm2: 5.4.3

You still need to upgrade MagicMirror. I recommend the official upgrade process.

@Volkae said in MMM-PublicTransportHafas - Error when loading - DeparturFetcher.mjs:

“version”: “2.30.0”,

You need to update MagicMirror. The module doesn’t work anymore with MagicMirror version 2.30.0.

@sdetweil said in MMM-PublicTransportHafas - Error when loading - DeparturFetcher.mjs:

@Volkae @p1lspeda @KristjanESPERANTO will have to advise next steps

I need the system information part from the logs. Like this:

[2025-01-14 20:05:03.529] [INFO]  System information:
### SYSTEM:    manufacturer: Raspberry Pi Foundation; model: Raspberry Pi 4 Model B Rev 1.5; virtual: false
### OS:        platform: linux; distro: Debian GNU/Linux; release: 12; arch: arm64; kernel: 6.1.21-v8+
### VERSIONS:  electron: 31.2.1; used node: 20.15.0; installed node: 22.4.1; npm: 10.8.1; pm2:
### OTHER:     timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

@Volkae said in MMM-PublicTransportHafas - Error when loading - DeparturFetcher.mjs:

MM is 2.30.0

Okay, I can see this when I downgrade to 2.30.0. With 2.31.0 the issue doesn’t appear. That was not the plan, but I’ll adjust requiresVersion accordingly.

Please update MM and check whether this solves the issue for you 🙂

@Vulan12354 I think it is probably because of the node version. Which version are you using? Run node -v to find out. And it would also be interesting to know which MagicMirror version you are using.

@mmmallday Nice! Don’t forget to add it to the module list 😀

MMM-page-indicator has been updated. The main change is that there are new classes that make it easier to customize the styling of the indicators and a new styling section in the README that describes some styling examples. Like this:

or this:

So if you use MMM-page-indicator, check it out 😀

The styling was also possible before, but was a little more complicated and the examples certainly help to develop your own cool styles.

Thanks to @mumblebaj for getting this rolling!

@ChrisLeduex said in Has anyone been able to get MMM-PetFinder to work?:

Do you recommend updating npm?

Since I prefer to have a somewhat up-to-date system, I make npm updates when I notice them. So far I haven’t had any problems with it.

I just registered and got an API key. I entered it and the module works :-) I didn’t used the secret key.

I use the mentioned fork and installed request manually.

Do you use the fork fromPhantomOffKanagawa?

The module needs request. Did you installed it via npm install request?

@mart11 This should be fixed since we released version 3.0.0 😀 Please update and check.

for MagicMirror purposes, is there a preferred style to be used for modules?

@kayakbabe I agree with Sam, but here’s a more detailed answer anyway: This depends on where you are. In some modules there are no rules for this - there and in your own modules it is, as Sam says, up to you.

However, to avoid poor code style, such as spaghetti code and inconsistently formatted code, which not only make maintenance and further development more difficult, but also affect team collaboration, many projects use static code analysis tools such as prettier and ESLint for checking code quality.

In the MagicMirror core (and with this in the default modules), we use the ESLint object-shorthand rule (see https://archive.eslint.org/docs/rules/object-shorthand) to ensure that only the shorthand version is used.

@kayakbabe said in Syntax Style for node_helper.js:

I see both ways done in node_helper.js in different modules.

The short variant is known as “Shorthand Method Names” and has been available since 2015 (with the release of ECMAScript 6).

https://ui.dev/shorthand-properties#shorthand-method-names

@Chloe282 Nice job! 👏 Thanks for sharing 😀

@Klinge MMM-Universal-Pir seems to be the newest. Have you checked that?

@mmmmh MMM-ISS-Live has a mute option.

@sdetweil said in MMM-FRITZ-Box-Callmonitor-py3 unknown_error:

i do not know how the module works but i suspect this
https://forum.magicmirror.builders/post/123380

Where do you see the connection? The maintainer of MMM-FRITZ-Box-Callmonitor-py3 is drtorchwood.

@rkorell It would be best if someone could be found who is willing to maintain the module. The module is open source, so the work could continue in a fork.

@chrisfr1976 Great. I have just adjusted the list in the wiki accordingly :-)