MMM-forecast-io -- Localized up to the minute weather

lavolp3

Guys, going through the thread, I see that a lot of good ideas were implemented in forks but not sent as PRs. I think it would be a good idea to have some of these included into the original. dmcinnes/MMM-forecast-io, since this is the one referenced in the original MagicMirror.

@dmcinnes what do you think?
Do you want this rep to be bloated up or do you want it to be kept mostly as it is and leave major changes to forks?

I would expect at least to have some of @morozgrafix very good ideas implemented as optional (sunset, precipitation probability).
Also @rak 's ideas look very very promising but I admit might be a bit much as changes for the master.

morozgrafix

@lavolp3 I haven’t pulled from master repo in a while and not sure if my changes are compatible at this point. I’m happy to clean it up, test it and submit a PR. Just let me know.

lavolp3

@morozgrafix Guess I’ll use the weekend to steal from all of you and build my perfect module. And learn stuff!
Might also send a few PRs then because I’m new to git and it really satisfies me :-D

morozgrafix

@lavolp3 One thing that I would suggest is to group your changes into relevant and smaller size chunks and submit separate PRs for those, instead of one massive PR. It’s easier for reviewers and for you in case you need to make changes based on comments. Cheers.

morozgrafix

@lavolp3 said in MMM-forecast-io -- Localized up to the minute weather:

Guys, going through the thread, I see that a lot of good ideas were implemented in forks but not sent as PRs. I think it would be a good idea to have some of these included into the original. dmcinnes/MMM-forecast-io, since this is the one referenced in the original MagicMirror.

@dmcinnes what do you think?
Do you want this rep to be bloated up or do you want it to be kept mostly as it is and leave major changes to forks?

I would expect at least to have some of @morozgrafix very good ideas implemented as optional (sunset, precipitation probability).
Also @rak 's ideas look very very promising but I admit might be a bit much as changes for the master.

I just submitted a PR for displaying Sunrise and Sunset times. https://github.com/dmcinnes/MMM-forecast-io/pull/22

~~I will try to find some time to improve wind forecast and get another PR submitted sometime this weekend.~~

I also just submitted a PR for wind speed and direction https://github.com/dmcinnes/MMM-forecast-io/pull/23

Precipitation probability forecast is also submitted as a PR: https://github.com/dmcinnes/MMM-forecast-io/pull/24

I also sneaked another PR that allows easy adjustments to forecast table look and feel: https://github.com/dmcinnes/MMM-forecast-io/pull/25

12wsx

what is the problem with my module? the problem is on monitor connected to raspberry pi Zero (using midori browser) where MagicMirror is installed.
My config:

/* Magic Mirror Config Sample
 *
 * By Michael Teeuw http://michaelteeuw.nl
 * MIT Licensed.
 *
 * For more information how you can configurate this file
 * See https://github.com/MichMich/MagicMirror#configuration
 *
 */

var config = {
	address: "::", // Address to listen on, can be:
	                      // - "localhost", "127.0.0.1", "::1" to listen on loopback interface
	                      // - another specific IPv4/6 to listen on a specific interface
	                      // - "", "0.0.0.0", "::" to listen on any interface
	                      // Default, when address config is left out, is "localhost"
	port: 8080,
	ipWhitelist: [], // Set [] to allow all IP addresses
	                                                       // or add a specific IPv4 of 192.168.1.5 :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.1.5"],
	                                                       // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"],

	language: "pl",
	timeFormat: 24,
	units: "metric",

	modules: [
		{
			module: "alert",
		},
		{
			module: "clock",
			position: "top_left"
		},
		{
			module: "calendar",
			position: "top_left",
			config: {
				calendars: [
					{
						symbol: "calendar-check-o ",
						url: "https://calendar.google.com/xxxxxxxx"
					}
				]
			}
		},
		{
			module: "MMM-Solartemp",
			position: "bottom_left",
			header: "Solartemp",
			config: {
				baseURL: "http://xxxxxxxxxx",
				key: "xxxxxxxxx",
				group: "xxxxxx",
				}
		},
		{
    			module: 'MMM-Remote-Control'
    			// uncomment the following line to show the URL of the remote control on the mirror
    			// , position: 'bottom_left'
    			// you can hide this module afterwards from the remote control itself
		},
		{
				module: 'MMM-forecast-io',
    				position: 'top_right',  // This can be any of the regions.
    				config: {
      				// See 'Configuration options' for more information.
      				apiKey: 'xxxxxxx', // Dark Sky API key.
      				maxDaysForecast: 5,
				forecastTableFontSize: 'small',
				// Only required if geolocation doesn't work:
      				latitude:  xx.xxxx,
      				longitude: xx.xxxx
				
				}
		},

		]

};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {module.exports = config;}

alt text

idoodler

@12wsx Are you using some custom CSS?

12wsx

no i don’t use custom css. But one thing- when I connect to magic mirror from my
computer (win7 /firefox) everything is ok.

idoodler

@12wsx Did you try using Chromium as a browser? Midori may have a hard time rendering the page.

henryluyu

Hi this is this module in my config.js.
I simply put the “MMM-forecast-io-master” folder in /modules/default, I have also put my actual api key, latitude and longtitude values also in MMM-forecast-io.js. But no weather is showing, other modules working fine. Can anyone help please?

	{
                    module: 'MMM-forecast-io',
                    position: 'top_right',  
                    config: {
                           apiKey: 'MYAPIKEY',
                           latitude:   53.4839,
                           longitude:  -2.2446
                    }
            },