Looking for Beta-testers!

Bangee

I’m now on the latest DEV version.

I had some problems to run it with my PIR Sensor.
this command helps to run it:

npm rebuild --runtime=electron-prebuilt --target=0.37.8 --disturl=https://atom.io/download/atom-shell --build-from-source

IpWithelist:
I’ve added my Subnet to de Withelist, but I can’t access my MagicMirror using a browser:

This device is not allowed to access your mirror.
Please check your config.js or config.js.sample to change this.

Would it be possible to add something like “Your IP-Adress: 192.168.0.99”?

ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1", ["192.168.0.99", "192.168.0.254"]],

This sould add a range from 192.168.0.99-192.168.0.254, or am I wrong?

Thanks for your help.

MichMich

@bangee: Check your node log. It should tell you which IP is trying to access the server. Good idea to add it to the “access denied” message. Will put it on my todo list. (PR is welcome!)

Bangee

@MichMich Thank you. I’ve had to update my config:
the Log told me:
Access denied to IP address: ::ffff:192.168.0.99

It works with this:

ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.0.1/24", "192.168.0.1/24"],

Jopyth

My mirror is now also running the development version, and I am experiencing restarts more often than before. I guess it is related to # 150 since there is no error in the log. Anyway I saw this twice yesterday, but this might just be something with a newer electron version, so maybe nothing we can fix. It is still a little bit annoying.

@MichMich By the way, do you have any particular date in mind for the release?

MichMich

No, can’t give you an ETA.

Keep me posted on the restart issue.

Jopyth

I am a little bit in the dark on the restart issue. It happens every time I change any file in my source code directory, i.e. config/config.js or even package.json.

All I have so far, is this appeared after I updated to development branch (hence updated all npm dependencies), plus I had to update my PIR-Sensor module (got a version XX expected, got XX error), and rebuild dependencies there also.

Does anyone have any idea on this? And is anyone else even seeing this behavior also? If I have time, I will try a complete reinstall and see if that fixes it.

MichMich

Arent you running any tool that watches your directory and restarts? Like nodemon or pm2?

Jopyth

I am using pm2 but watch & reload was disabled.

I did a complete update, which apparently helped people before with #150, that seems to have fixed it:

sudo apt-get update
sudo apt-get upgrade
sudo apt-get dist-upgrade
sudo apt-get clean
sudo rpi-update

gismo2006

@Jopyth some time ago my mirror suddenly didn’t work whit pm2. From one day to the other. I changed nothing and it works fine before. I didn’t know what happens. But then I found a little order in the display when I prompt pm2 start mm… I didn’ t rember the order but I know pm2 worked some second displayed something and then everything works fine again. …

Maybe you found something , too

Greets gismo

MichMich

Guys, I’ve just made a modification that hides a region if all modules in a region are hidden. This should prevent unwanted margins when a region (like the top_bar) only contains hidden modules. This allows my to move the updatenotification module to the topbar.

Due to the nature of the change, this could cause some serious issues if it contains any missed bugs. It would be great if you guys gan pull the latest version and let me know if everything keeps working. If you’re having issues with some modules not showing up, please let me know.

More info about this change can be found here: https://github.com/MichMich/MagicMirror/commit/e4197012f65778f815cd73a6c7fab1a30ef3b92f

Thanks!

ESOB

@MichMich I am on the latest develop and it throws an error and just gives me a black screen:

> magicmirror@2.1.1 start /home/pi/MagicMirror
> sh run-start.sh

Starting MagicMirror: v2.1.1
Loading config ...
App threw an error during load
TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.resolve (path.js:1148:7)
    at loadConfig (/home/pi/MagicMirror/js/app.js:53:29)
    at App.start (/home/pi/MagicMirror/js/app.js:180:3)
    at Object. (/home/pi/MagicMirror/js/electron.js:102:6)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
Whoops! There was an uncaught exception...
TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.resolve (path.js:1148:7)
    at loadConfig (/home/pi/MagicMirror/js/app.js:53:29)
    at App.start (/home/pi/MagicMirror/js/app.js:180:3)
    at Object. (/home/pi/MagicMirror/js/electron.js:102:6)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
Launching application.

When I jump back to Master branch it loads fine:

//your code> magicmirror@2.1.0 start /home/pi/MagicMirror
> electron js/electron.js

Starting MagicMirror: v2.1.0
Loading config ...
Loading module helpers ...
No helper found for module: alert.
Initializing new module helper ...
No helper found for module: clock.
Initializing new module helper ...
Initializing new module helper ...
Initializing new module helper ...
Initializing new module helper ...
Initializing new module helper ...
All module helpers loaded.
Starting server op port 8080 ... 
Server started ...
Connecting socket for: MMM-Remote-Control
Starting node helper for: MMM-Remote-Control
Connecting socket for: calendar
Starting node helper for: calendar
Connecting socket for: MMM-Traffic
MMM-Traffic helper started ...
Connecting socket for: MMM-WunderGround
MMM-WunderGround helper started ...
Connecting socket for: MMM-NFL
Starting module: MMM-NFL
Connecting socket for: newsfeed
Starting module: newsfeed
Sockets connected & modules started ...
Launching application.
ERROR! Could not find main module js

Snille

Hi there, got the same problem… It’s time for bed anyway. :)

roramirez

So… that is my mistake. I pushed fix the wrong validation :(
https://github.com/MichMich/MagicMirror/pull/658

MichMich

I’ve just merged the fix!👍

Snille

Working. :)

XxX_Cobra_XxX

@MichMich I have the same problem as ESOB:

I am now also on the latest develop and it throws an error and just gives me a black screen:

WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'rrule-alt'
App threw an error during load
Error: Cannot find module 'rrule-alt'
    at Module._resolveFilename (module.js:455:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object. (/home/pi/MagicMirror/modules/default/calendar/vendor/ical.js/node-ical.js:20:13)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
{ Error: Cannot find module 'rrule-alt'
    at Module._resolveFilename (module.js:455:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object. (/home/pi/MagicMirror/modules/default/calendar/vendor/ical.js/node-ical.js:20:13)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12) code: 'MODULE_NOT_FOUND' }

When I go back to Master branch it loads normally.

Please help me

strawberry 3.141

@XxX_Cobra_XxX did you install the dependencies? they have changed for the develop branch

XxX_Cobra_XxX

@strawberry-3.141 I have installed the dependencies now with ‘npm install’ and it works! ;-)

Thank you very much

roramirez

Hey Guys,

To prevent problems like the error on validation on develop branch I say to you we are working a test suite for MagicMirror.

Now is initial state with some tests. Today @MichMich merged a change with some testing for e2e area. At now isn’t integrated the e2e tests in Travis. You can run e2e tests with

export DISPLAY=:0 && npm run test:e2e
You need run npm install before

The build a test is simple. If someone is animated and want to build one or need some light let me know.

So, also it helps if you run the e2e tests into your system and tells us if something is wrong or good.

morozgrafix

@roramirez I just submitted PR to add chai-as-promised to devDependencies. I was missing it from globally installed packages and ran into an error when tried to run tests.